Re: [U-Boot] [RFC] common/lcd: use lcd_setcolreg() in bitmap_plot

2012-10-29 Thread Bo Shen
On 10/26/2012 19:23, Andreas Bießmann wrote: The lcd_setcolreg() is a API provided by the lcd driver and used to setup the color lookup table. However the lcd driver setup the CLUT by using a lot of #ifdiffery and accessing the CLUT arrays which are cleanly hidden by the API call. Remove that and

Re: [U-Boot] [RFC] common/lcd: use lcd_setcolreg() in bitmap_plot

2012-10-29 Thread Andreas Bießmann
Hi Nikita, On 28.10.2012 08:10, Nikita Kiryanov wrote: > Hi Andreas, > > I think this change can also be applied to lcd_display_bitmap(), and > then configuration_get_cmap() can be eliminated. hopefully yes, but first of all I would like to hear that the change can work on all supported devices,

Re: [U-Boot] [RFC] common/lcd: use lcd_setcolreg() in bitmap_plot

2012-10-28 Thread Nikita Kiryanov
Hi Andreas, I think this change can also be applied to lcd_display_bitmap(), and then configuration_get_cmap() can be eliminated. -- Regards, Nikita. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [RFC] common/lcd: use lcd_setcolreg() in bitmap_plot

2012-10-26 Thread Andreas Bießmann
The lcd_setcolreg() is a API provided by the lcd driver and used to setup the color lookup table. However the lcd driver setup the CLUT by using a lot of #ifdiffery and accessing the CLUT arrays which are cleanly hidden by the API call. Remove that and use the API. Signed-off-by: Andreas Bießmann