Re: [U-Boot] [RFC][PATCH 08/19] i2c: fix command usage help

2010-07-29 Thread Heiko Schocher
Hello Peter, Peter Tyser wrote: >> { >> cmd_tbl_t *c; >> >> +if (argc < 2) { >> +cmd_usage(cmdtp); >> +return 1; >> +} >> + > > Wolfgang recently made cmd_usage() return 1 so the above could be > simplified to: > if (argc < 2) > return cmd_usage(cmdtp);

Re: [U-Boot] [RFC][PATCH 08/19] i2c: fix command usage help

2010-07-29 Thread Peter Tyser
> { > cmd_tbl_t *c; > > + if (argc < 2) { > + cmd_usage(cmdtp); > + return 1; > + } > + Wolfgang recently made cmd_usage() return 1 so the above could be simplified to: if (argc < 2) return cmd_usage(cmdtp); Best, Peter

[U-Boot] [RFC][PATCH 08/19] i2c: fix command usage help

2010-07-29 Thread Heiko Schocher
Signed-off-by: Heiko Schocher --- common/cmd_i2c.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c index a1a84a1..91e60ae 100644 --- a/common/cmd_i2c.c +++ b/common/cmd_i2c.c @@ -1297,6 +1297,11 @@ static int do_i2c(cmd_tbl_t * cmdt