Re: [U-Boot] [RFC/PATCH] common/command.c: Guard strchr/strlen from NULL pointer

2010-11-24 Thread Sergei Shtylyov
Hello. On 24-11-2010 13:15, Thomas Weber wrote: > Guard strchr/strlen from being called with NULL pointer. > This line is crashing on OMAP3/Devkit8000 when command "env" is called > without subcommand. > Toolchain is Codesourcery 2010q1. > The cmd is NULL in this case because the calling funct

Re: [U-Boot] [RFC/PATCH] common/command.c: Guard strchr/strlen from NULL pointer

2010-11-24 Thread Wolfgang Denk
Dear Thomas Weber, In message <1290593751-540-1-git-send-email-we...@corscience.de> you wrote: > Guard strchr/strlen from being called with NULL pointer. > This line is crashing on OMAP3/Devkit8000 when command "env" is called > without subcommand. > > Toolchain is Codesourcery 2010q1. > > The

[U-Boot] [RFC/PATCH] common/command.c: Guard strchr/strlen from NULL pointer

2010-11-24 Thread Thomas Weber
Guard strchr/strlen from being called with NULL pointer. This line is crashing on OMAP3/Devkit8000 when command "env" is called without subcommand. Toolchain is Codesourcery 2010q1. The cmd is NULL in this case because the calling function "do_env" decremented the argc without checking if the