Re: [U-Boot] [RESEND] drivers/usb/ehci: Use platform-specific accessors

2017-10-31 Thread Vladimir Boroda
Alexey, I tested the patch on PowerPC.  Seems to work fine, but you have to make sure to set the proper order of arguments for when the EHCI registers are big endian:  __raw_writel(cpu_to_be32(b), a) To test this patch I had to verify that __raw_ functions are supported for PowerPC, so I created

Re: [U-Boot] [RESEND] drivers/usb/ehci: Use platform-specific accessors

2017-10-30 Thread Alexey Brodkin
Hi Marek, Vladimir, On Sun, 2017-10-29 at 11:00 +0100, Marek Vasut wrote: > On 10/27/2017 02:42 PM, Vladimir Boroda wrote: > > > > Alexey/Marek, > > > > It appears that the "drivers/usb/ehci: Use platform-specific accessors" > > patch that was submitted in June (and currently adopted in U-Boot >

Re: [U-Boot] [RESEND] drivers/usb/ehci: Use platform-specific accessors

2017-10-27 Thread Vladimir Boroda
This patch should have been rejected. It no longer breaks the build, but it break the functionality on big-endian systems. The readl() and writel() macros already do the endian conversion assuming the port is in little-endian format. So after this patch the EHCI registers are now read incorre

[U-Boot] [RESEND] drivers/usb/ehci: Use platform-specific accessors

2017-06-05 Thread Alexey Brodkin
From: Alexey Brodkin Current implementation doesn't allow utilization of platform-specific reads and writes. But some arches or platforms may want to use their accessors that do some extra work like adding barriers for data serialization etc. Interesting enough OHCI accessors already do that so