Re: [U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub

2015-04-13 Thread Marek Vasut
On Monday, April 13, 2015 at 05:20:38 PM, Dinh Nguyen wrote: > On 04/11/2015 11:57 AM, Marek Vasut wrote: > > On Tuesday, April 07, 2015 at 04:31:43 PM, Dinh Nguyen wrote: > >> On Fri, 3 Apr 2015, Marek Vasut wrote: > >>> On Tuesday, March 31, 2015 at 12:01:11 AM, > >>> dingu...@opensource.altera.c

Re: [U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub

2015-04-13 Thread Dinh Nguyen
On 04/11/2015 11:57 AM, Marek Vasut wrote: > On Tuesday, April 07, 2015 at 04:31:43 PM, Dinh Nguyen wrote: >> On Fri, 3 Apr 2015, Marek Vasut wrote: >>> On Tuesday, March 31, 2015 at 12:01:11 AM, dingu...@opensource.altera.com > wrote: From: Dinh Nguyen Add a stub s_init function i

Re: [U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub

2015-04-11 Thread Marek Vasut
On Tuesday, April 07, 2015 at 04:31:43 PM, Dinh Nguyen wrote: > On Fri, 3 Apr 2015, Marek Vasut wrote: > > On Tuesday, March 31, 2015 at 12:01:11 AM, dingu...@opensource.altera.com wrote: > > > From: Dinh Nguyen > > > > > > Add a stub s_init function in the board file. > > > > Why do you add th

Re: [U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub

2015-04-07 Thread Dinh Nguyen
On Fri, 3 Apr 2015, Marek Vasut wrote: > On Tuesday, March 31, 2015 at 12:01:11 AM, dingu...@opensource.altera.com > wrote: > > From: Dinh Nguyen > > > > Add a stub s_init function in the board file. > > Why do you add this stub function ? The commit message should > clarify why the patch is n

Re: [U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub

2015-04-02 Thread Marek Vasut
On Tuesday, March 31, 2015 at 12:01:11 AM, dingu...@opensource.altera.com wrote: > From: Dinh Nguyen > > Add a stub s_init function in the board file. Why do you add this stub function ? The commit message should clarify why the patch is needed. > Signed-off-by: Dinh Nguyen [...] Best regard

[U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub

2015-03-30 Thread dinguyen
From: Dinh Nguyen Add a stub s_init function in the board file. Signed-off-by: Dinh Nguyen --- v3: move the contents of s_init into board_init_f v2: remove redundant code that is already in arch_early_init_r --- board/altera/socfpga/socfpga.c | 2 ++ 1 file changed, 2 insertions(+) diff --git