Re: [U-Boot] [PATCHv2 3/4] env_nand.c: clarify log messages when env reading fails

2013-02-25 Thread Scott Wood
On 02/25/2013 03:39:12 AM, Phil Sutter wrote: Scott, On Fri, Feb 22, 2013 at 07:59:41PM -0600, Scott Wood wrote: > We should also give a message if one of the CRCs is bad, though that's > an existing problem. Yes, that would be nice. While writing this, I also had the idea of introducing som

Re: [U-Boot] [PATCHv2 3/4] env_nand.c: clarify log messages when env reading fails

2013-02-25 Thread Phil Sutter
Scott, On Fri, Feb 22, 2013 at 07:59:41PM -0600, Scott Wood wrote: > On Thu, Feb 21, 2013 at 06:21:55PM +0100, Phil Sutter wrote: > > The single message is misleading, since there is no equivalent success > > note when reading the other copy succeeds. Instead, warn if one of the > > redundant copi

Re: [U-Boot] [PATCHv2 3/4] env_nand.c: clarify log messages when env reading fails

2013-02-22 Thread Scott Wood
On Thu, Feb 21, 2013 at 06:21:55PM +0100, Phil Sutter wrote: > The single message is misleading, since there is no equivalent success > note when reading the other copy succeeds. Instead, warn if one of the > redundant copies could not be loaded and emphasise on the error when > reading both fails.

[U-Boot] [PATCHv2 3/4] env_nand.c: clarify log messages when env reading fails

2013-02-21 Thread Phil Sutter
The single message is misleading, since there is no equivalent success note when reading the other copy succeeds. Instead, warn if one of the redundant copies could not be loaded and emphasise on the error when reading both fails. Signed-off-by: Phil Sutter --- common/env_nand.c | 12 -