Re: [U-Boot] [PATCH v7 4/4] Add USB support for Efika

On Wednesday, September 28, 2011 02:25:14 PM Jana Rapava wrote: > 2011/9/28 Marek Vasut > > > > +/* get ID from ULPI immediate registers */ > > > +for (reg = ULPI_ID_REGS_COUNT - 1; reg >= 0; reg--) > > > +tmp |= ulpi_read(ehci, (u32)reg) << (reg * 8); > > > > Are you ignoring my

Re: [U-Boot] [PATCH v7 4/4] Add USB support for Efika

2011/9/28 Marek Vasut > > +/* get ID from ULPI immediate registers */ > > +for (reg = ULPI_ID_REGS_COUNT - 1; reg >= 0; reg--) > > +tmp |= ulpi_read(ehci, (u32)reg) << (reg * 8); > > Are you ignoring my comment and picking only some of them? Is the cast here > necessary? > Sorry,

Re: [U-Boot] [PATCH v7 4/4] Add USB support for Efika

> This commit adds USB support for EfikaMX and EfikaSB. > > Signed-off-by: Jana Rapava > Signed-off-by: Marek Vasut > Cc: Remy Bohmer > Cc: Stefano Babic > --- > Changes for v2: >      - changed to proper patch > Changes for v3: >      - merged other USB patches from u-boot-pxa/efikasb >   

[U-Boot] [PATCH v7 4/4] Add USB support for Efika

This commit adds USB support for EfikaMX and EfikaSB. Signed-off-by: Jana Rapava Signed-off-by: Marek Vasut Cc: Remy Bohmer Cc: Stefano Babic --- Changes for v2: - changed to proper patch Changes for v3: - merged other USB patches from u-boot-pxa/efikasb - offset-based access changed