Hi Wolfgang,
2011/4/30 Wolfgang Denk :
> Dear Macpaul Lin,
>
> It means adding any new code to U-Boot which includes "typedef"s.
>
>> According to the checkpatch result, "typedef" warning exists in 4 files.
>> arch/nds32/include/asm/posix_types.h
>> arch/nds32/include/asm/types.h
>> arch/nds32/inc
On Sat, Apr 30, 2011 at 7:09 AM, Wolfgang Denk wrote:
> Dear Macpaul Lin,
>
> In message you wrote:
>>
>> I think we still have to discuss about the typedef's.
>> What does the "new" typedef means?
>
> It means adding any new code to U-Boot which includes "typedef"s.
>
>> According to the checkpa
Dear Macpaul Lin,
In message you wrote:
>
> I think we still have to discuss about the typedef's.
> What does the "new" typedef means?
It means adding any new code to U-Boot which includes "typedef"s.
> According to the checkpatch result, "typedef" warning exists in 4 files.
> arch/nds32/inclu
Hi Wolfgang,
>>> I did check typedefs one by one by myself in hand and eye checking.
>>> If some thing is not suitable for using "typedefs" please let me know.
>>
>> Please don't add any new typedef's.
>>
>
> I think we still have to discuss about the typedef's.
> What does the "new" typedef means
Hi Wolfgang,
>> > Checkpatch complains a lot about "do not add new typedefs".
>>
>> Indeed, but this seems is special for Linux Kernel,
>
> Not really. This is Linux CodingStyle policy, which we usually adapt.
>
>> I've checked some of the "typedefs" from other architecture code in u-boot.
>
> Th
Hi Wolfgang,
> This also triggers an erro-r from checkpatch, and indeed this is a
> strange define.
>
> > +#define R0 uregs[1]/* R0 */
> > +#define R1 uregs[2]
> > +#define R2 uregs[3]
> > +#define R3 uregs[4]
>
> NAK. Please use a C struct instead.
Aft
Dear Macpaul Lin,
In message you wrote:
>
> > Checkpatch complains a lot about "do not add new typedefs".
>
> Indeed, but this seems is special for Linux Kernel,
Not really. This is Linux CodingStyle policy, which we usually adapt.
> I've checked some of the "typedefs" from other architectur
Hi Wolfgang,
2011/4/7 Wolfgang Denk :
Dear Macpaul Lin,
>> Add generic header files support for nds32 architecture.
>> Cache, ptregs, data type and other definitions are included.
>>
>> Signed-off-by: Macpaul Lin
>
> Checkpatch complains a lot about "do not add new typedefs".
Indeed, but this s
Dear Macpaul Lin,
In message <1302180333-25372-1-git-send-email-macp...@andestech.com> you wrote:
> Add generic header files support for nds32 architecture.
> Cache, ptregs, data type and other definitions are included.
>
> Signed-off-by: Macpaul Lin
Checkpatch complains a lot about "do not add
Add generic header files support for nds32 architecture.
Cache, ptregs, data type and other definitions are included.
Signed-off-by: Macpaul Lin
---
Changes for v1-v4:
- Code cleanup and style formatting.
Changes for v5-v6:
- This patch also updated the following changes against the
c
10 matches
Mail list logo
