Re: [U-Boot] [PATCH v6 1/3] dm: implement a Timer uclass

2015-10-09 Thread Thomas Chou
Hi Bin, On 10/09/2015 06:46 PM, Bin Meng wrote: But in v7, it is gd->dm_timer. I think it should be gd->timer? I think it is only CONFIG_DM_TIMER, that Simon suggested to change. In the gd structure, I keep it neighbor to dm_root. In the initr_dm(), they are set to NULL similarly. So I would

Re: [U-Boot] [PATCH v6 1/3] dm: implement a Timer uclass

2015-10-09 Thread Bin Meng
Hi Thomas, On Fri, Oct 9, 2015 at 6:44 PM, Thomas Chou wrote: > Hi Simon, > > On 10/09/2015 05:36 PM, Simon Glass wrote: >>> >>> v6 >>>rename to CONFIG_TIMER as Simon suggested. >> >> >> But note you have changed this too broadly - 'TIMER' appears in >> several places where it should be 'time

Re: [U-Boot] [PATCH v6 1/3] dm: implement a Timer uclass

2015-10-09 Thread Thomas Chou
Hi Simon, On 10/09/2015 05:36 PM, Simon Glass wrote: v6 rename to CONFIG_TIMER as Simon suggested. But note you have changed this too broadly - 'TIMER' appears in several places where it should be 'timer'. Sorry, I made a mistake in the string replacement. Please see v7. Best regards, Th

Re: [U-Boot] [PATCH v6 1/3] dm: implement a Timer uclass

2015-10-09 Thread Simon Glass
Hi Thomas, On 9 October 2015 at 02:17, Thomas Chou wrote: > Implement a Timer uclass to work with lib/time.c. > > Signed-off-by: Thomas Chou > Acked-by: Simon Glass > --- > v2 > fix coding style. > v3 > add description to Kconfig as Simon suggested. > move timer.c code to lib/time.c. >

[U-Boot] [PATCH v6 1/3] dm: implement a Timer uclass

2015-10-08 Thread Thomas Chou
Implement a Timer uclass to work with lib/time.c. Signed-off-by: Thomas Chou Acked-by: Simon Glass --- v2 fix coding style. v3 add description to Kconfig as Simon suggested. move timer.c code to lib/time.c. add dm_timer dev to global data. remove timer_init(). change API name get_clo