Re: [U-Boot] [PATCH v6 1/3] PXA: PXA27x Matrix keypad driver

2012-01-25 Thread Marek Vasut
> 2012/1/25 Marek Vasut : > >> From: Marek Vasut > >> > >> Signed-off-by: Marek Vasut > >> Signed-off-by: Vasily Khoruzhick > >> [vasily: adapted Marek's old version for newer u-boot, > >> fixed multiple keypresses handling] > > > > Fine ... albert, can you comment on it? > > > > Vas

Re: [U-Boot] [PATCH v6 1/3] PXA: PXA27x Matrix keypad driver

2012-01-25 Thread Vasily Khoruzhick
2012/1/25 Marek Vasut : >> From: Marek Vasut >> >> Signed-off-by: Marek Vasut >> Signed-off-by: Vasily Khoruzhick >> [vasily: adapted Marek's old version for newer u-boot, >>          fixed multiple keypresses handling] > > Fine ... albert, can you comment on it? > > Vasily, do you think this co

Re: [U-Boot] [PATCH v6 1/3] PXA: PXA27x Matrix keypad driver

2012-01-25 Thread Marek Vasut
> From: Marek Vasut > > Signed-off-by: Marek Vasut > Signed-off-by: Vasily Khoruzhick > [vasily: adapted Marek's old version for newer u-boot, > fixed multiple keypresses handling] Fine ... albert, can you comment on it? Vasily, do you think this code is good? I want an honest answer

[U-Boot] [PATCH v6 1/3] PXA: PXA27x Matrix keypad driver

2012-01-25 Thread Vasily Khoruzhick
From: Marek Vasut Signed-off-by: Marek Vasut Signed-off-by: Vasily Khoruzhick [vasily: adapted Marek's old version for newer u-boot, fixed multiple keypresses handling] --- v2: use struct-based access to regs, minor cleanup v3: fix multiple keypresses handling, minor cleanup v4: anothe