Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-07 Thread Chin Liang See
Hi Michal, On Fri, 2014-03-07 at 09:12 +0100, Michal Simek wrote: > On 03/05/2014 08:00 PM, Chin Liang See wrote: > > On Wed, 2014-03-05 at 19:47 +0100, Michal Simek wrote: > >> Hi Pavel, > >> > >> > >> 2014-03-05 17:13 GMT+01:00 Pavel Machek : > >> Hi! > >> > >> > Also I

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-07 Thread Michal Simek
On 03/05/2014 08:00 PM, Chin Liang See wrote: > On Wed, 2014-03-05 at 19:47 +0100, Michal Simek wrote: >> Hi Pavel, >> >> >> 2014-03-05 17:13 GMT+01:00 Pavel Machek : >> Hi! >> >> > Also I expect that you can change all pins for >> uarts/ethernets/spi/i2c/etc >>

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-05 Thread Chin Liang See
On Wed, 2014-03-05 at 19:47 +0100, Michal Simek wrote: > Hi Pavel, > > > 2014-03-05 17:13 GMT+01:00 Pavel Machek : > Hi! > > > Also I expect that you can change all pins for > uarts/ethernets/spi/i2c/etc > > that's why there is no golden configuration for

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-05 Thread Michal Simek
Hi Pavel, 2014-03-05 17:13 GMT+01:00 Pavel Machek : > Hi! > > > Also I expect that you can change all pins for > uarts/ethernets/spi/i2c/etc > > that's why there is no golden configuration for socfpga that's why > > it is better to keep it empty just to compile it. > > Well, there are some devel

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-05 Thread Chin Liang See
On Wed, 2014-03-05 at 17:15 +0100, ZY - pavel wrote: > Hi! > > > > I changed that to if (!scan_chain_engine_is_idle(SCAN_MAX_DELAY)) > > It should much better now > > Yes, thanks. > > > Removed. Thanks > > Thanks for all the changes, it looks better now, so you have my > Acked-by in another th

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-05 Thread Chin Liang See
Hi Pavel, On Mon, 2014-03-03 at 21:41 +0100, ZY - pavel wrote: > Hi! > > > Scan Manager driver will be called to configure the IOCSR > > scan chain. This configuration will setup the IO buffer settings > > > > Signed-off-by: Chin Liang See > > Cc: Dinh Nguyen > > Cc: Wolfgang Denk > > CC: Pav

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-05 Thread Pavel Machek
Hi! > I changed that to if (!scan_chain_engine_is_idle(SCAN_MAX_DELAY)) > It should much better now Yes, thanks. > Removed. Thanks Thanks for all the changes, it looks better now, so you have my Acked-by in another thread.

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-05 Thread Pavel Machek
Hi! > Also I expect that you can change all pins for uarts/ethernets/spi/i2c/etc > that's why there is no golden configuration for socfpga that's why > it is better to keep it empty just to compile it. Well, there are some development boards around... and having u-boot able to boot on the devel b

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-04 Thread Michal Simek
On 03/04/2014 04:01 PM, Chin Liang See wrote: > Hi Michal, > > On Fri, 2014-02-28 at 11:17 +0100, Michal Simek wrote: >> On 02/27/2014 05:03 PM, Chin Liang See wrote: >>> Scan Manager driver will be called to configure the IOCSR >>> scan chain. This configuration will setup the IO buffer settings

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-04 Thread Chin Liang See
Hi Michal, On Fri, 2014-02-28 at 11:17 +0100, Michal Simek wrote: > On 02/27/2014 05:03 PM, Chin Liang See wrote: > > Scan Manager driver will be called to configure the IOCSR > > scan chain. This configuration will setup the IO buffer settings > > > > Signed-off-by: Chin Liang See > > Cc: Dinh

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-03-03 Thread Pavel Machek
Hi! > Scan Manager driver will be called to configure the IOCSR > scan chain. This configuration will setup the IO buffer settings > > Signed-off-by: Chin Liang See > Cc: Dinh Nguyen > Cc: Wolfgang Denk > CC: Pavel Machek > Cc: Tom Rini > Cc: Albert Aribaud > +static inline uint32_t scan_c

Re: [U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-02-28 Thread Michal Simek
On 02/27/2014 05:03 PM, Chin Liang See wrote: > Scan Manager driver will be called to configure the IOCSR > scan chain. This configuration will setup the IO buffer settings > > Signed-off-by: Chin Liang See > Cc: Dinh Nguyen > Cc: Wolfgang Denk > CC: Pavel Machek > Cc: Tom Rini > Cc: Albert A

[U-Boot] [PATCH v6] socfpga: Adding Scan Manager driver

2014-02-27 Thread Chin Liang See
Scan Manager driver will be called to configure the IOCSR scan chain. This configuration will setup the IO buffer settings Signed-off-by: Chin Liang See Cc: Dinh Nguyen Cc: Wolfgang Denk CC: Pavel Machek Cc: Tom Rini Cc: Albert Aribaud --- Changes for v6 - Fixed various coding style issue Ch