Re: [U-Boot] [PATCH v5 4/4] Add USB support for Efika

2011-09-29 Thread Marek Vasut
On Thursday, September 29, 2011 01:09:57 PM Jana Rapava wrote: > This commit adds USB support for EfikaMX and EfikaSB. > > Signed-off-by: Jana Rapava > Signed-off-by: Marek Vasut > Cc: Remy Bohmer > Cc: Stefano Babic > --- > Changes for v2: > - introduce temporary variable in ulpi_write >

[U-Boot] [PATCH v5 4/4] Add USB support for Efika

2011-09-29 Thread Jana Rapava
This commit adds USB support for EfikaMX and EfikaSB. Signed-off-by: Jana Rapava Signed-off-by: Marek Vasut Cc: Remy Bohmer Cc: Stefano Babic --- Changes for v2: - introduce temporary variable in ulpi_write - whitespace changes Changes for v3: - add protection against multiple

Re: [U-Boot] [PATCH v5 4/4] Add USB support for Efika

2011-09-28 Thread Jana Rapava
2011/9/28 Stefano Babic > This two patches are already accepted and integrated into > u-boot-imx/next and in u-boot-arm/next. > You can take u-boot-imx/next as reference for your patchset > > > > > I don't know if they should be part of this patchset, > > No, they don't > Thanks, Marek already t

Re: [U-Boot] [PATCH v5 4/4] Add USB support for Efika

2011-09-28 Thread Stefano Babic
On 09/27/2011 08:17 PM, Jana Rapava wrote: > > > + > > +#ifdef CONFIG_MACH_EFIKASB > > Please update to mainline, use if (machine_is_efikasb()) { ... } . > > > To get macro machine_is_efikasb() working, I have to get into mainline > these two of your patches in u-boot-marex:

Re: [U-Boot] [PATCH v5 4/4] Add USB support for Efika

2011-09-27 Thread Marek Vasut
On Tuesday, September 27, 2011 08:17:27 PM Jana Rapava wrote: > > > + > > > +#ifdef CONFIG_MACH_EFIKASB > > Please update to mainline, use if (machine_is_efikasb()) { ... } . > > > To get macro machine_is_efikasb() working, I have to get into mainline > these two of your patches in u-boot-

Re: [U-Boot] [PATCH v5 4/4] Add USB support for Efika

2011-09-27 Thread Jana Rapava
> > + > > +#ifdef CONFIG_MACH_EFIKASB Please update to mainline, use if (machine_is_efikasb()) { ... } . > To get macro machine_is_efikasb() working, I have to get into mainline these two of your patches in u-boot-marex: 430eacfcf35b1f54b0a1ead989aefe63e2996846 EfikaMX: Add imximage confi

Re: [U-Boot] [PATCH v5 4/4] Add USB support for Efika

2011-09-27 Thread Marek Vasut
On Tuesday, September 27, 2011 04:12:18 PM Jana Rapava wrote: > 2011/9/27 Marek Vasut > > > > /* > > > > > > + * EHCI USB > > > + */ > > > +#ifdef CONFIG_CMD_USB > > > +void setup_iomux_usb(void); > > > +#else > > > +static inline void setup_iomux_usb(void) { } > > > +#endif > > > + > >

Re: [U-Boot] [PATCH v5 4/4] Add USB support for Efika

2011-09-27 Thread Jana Rapava
2011/9/27 Marek Vasut > > > /* > > + * EHCI USB > > + */ > > +#ifdef CONFIG_CMD_USB > > +void setup_iomux_usb(void); > > +#else > > +static inline void setup_iomux_usb(void) { } > > +#endif > > + > > Can you introduce efika.h header and move this to the header please. > Should I move all

Re: [U-Boot] [PATCH v5 4/4] Add USB support for Efika

2011-09-27 Thread Marek Vasut
On Tuesday, September 27, 2011 01:01:36 PM Jana Rapava wrote: > This commit adds USB support for EfikaMX and EfikaSB. > > Signed-off-by: Jana Rapava > Signed-off-by: Marek Vasut > Cc: Remy Bohmer > Cc: Stefano Babic > --- [...] > + > +#ifdef CONFIG_MACH_EFIKASB Please update to mainli

[U-Boot] [PATCH v5 4/4] Add USB support for Efika

2011-09-27 Thread Jana Rapava
This commit adds USB support for EfikaMX and EfikaSB. Signed-off-by: Jana Rapava Signed-off-by: Marek Vasut Cc: Remy Bohmer Cc: Stefano Babic --- Changes for v2: - changed to proper patch Changes for v3: - merged other USB patches from u-boot-pxa/efikasb - offset-based access ch