Re: [U-Boot] [PATCH v5 4/4] ARM: SAMSUNG: support sdhci controller

2012-04-13 Thread Minkyu Kang
On 13 April 2012 15:30, Graeme Russ wrote: > Hi Prabhakar, > > On Fri, Apr 13, 2012 at 4:16 PM, Prabhakar Lad > wrote: >> Hi Jaehoon, >> > > [snip] > >>    There is no consistency for the #define  CONFIG_S5P_SDHCI, >>    few have been assigned to value 1, And looking at the patchset >>    the val

Re: [U-Boot] [PATCH v5 4/4] ARM: SAMSUNG: support sdhci controller

2012-04-12 Thread Graeme Russ
Hi Prabhakar, On Fri, Apr 13, 2012 at 4:16 PM, Prabhakar Lad wrote: > Hi Jaehoon, > [snip] >    There is no consistency for the #define  CONFIG_S5P_SDHCI, >    few have been assigned to value 1, And looking at the patchset >    the value of it is not used if I am not wrong, depending or defined

Re: [U-Boot] [PATCH v5 4/4] ARM: SAMSUNG: support sdhci controller

2012-04-12 Thread Prabhakar Lad
Hi Jaehoon, On Thu, Apr 12, 2012 at 4:29 PM, Jaehoon Chung wrote: > To support sdhci controller, remove the CONFIG_S5P_MMC.. > Instead, use the CONFIG_S5P_SDHCI/CONFIG_SDHCI. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park > Acked-by: Lei Wen > --- >  include/configs/origen.h  

Re: [U-Boot] [PATCH v5 4/4] ARM: SAMSUNG: support sdhci controller

2012-04-12 Thread Minkyu Kang
On 12 April 2012 19:59, Jaehoon Chung wrote: > To support sdhci controller, remove the CONFIG_S5P_MMC.. > Instead, use the CONFIG_S5P_SDHCI/CONFIG_SDHCI. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park > Acked-by: Lei Wen > --- >  include/configs/origen.h            |    3 ++- >

[U-Boot] [PATCH v5 4/4] ARM: SAMSUNG: support sdhci controller

2012-04-12 Thread Jaehoon Chung
To support sdhci controller, remove the CONFIG_S5P_MMC.. Instead, use the CONFIG_S5P_SDHCI/CONFIG_SDHCI. Signed-off-by: Jaehoon Chung Signed-off-by: Kyungmin Park Acked-by: Lei Wen --- include/configs/origen.h|3 ++- include/configs/s5p_goni.h |3 ++- include/config