Re: [U-Boot] [PATCH v5] Fix board init code to respect the C runtime environment

2015-11-20 Thread Albert ARIBAUD
Hello Simon, On Wed, 18 Nov 2015 18:05:07 -0700, Simon Glass wrote: > Hi Albert, > > >> early malloc() area > > > > "Arena", and "malloc arena", are established designations for the > > memory space used by malloc implementations; and I prefer to use this > > more specific term, as people may us

Re: [U-Boot] [PATCH v5] Fix board init code to respect the C runtime environment

2015-11-18 Thread Simon Glass
Hi Albert, On 17 November 2015 at 05:59, Albert ARIBAUD wrote: > Hello Simon, > > On Mon, 16 Nov 2015 21:11:38 -0700, Simon Glass > wrote: > >> > +++ b/arch/arm/lib/crt0.S >> > @@ -82,9 +82,11 @@ ENTRY(_main) >> > #else >> > bic sp, sp, #7 /* 8-byte alignment for ABI compliance

Re: [U-Boot] [PATCH v5] Fix board init code to respect the C runtime environment

2015-11-17 Thread Albert ARIBAUD
... and of course, I forgot to add a note at '(*)' re the malloc arena size alignment... On Tue, 17 Nov 2015 13:59:32 +0100, Albert ARIBAUD wrote: > Hello Simon, > Indeed, no attempt is made to check that it is aligned (and no attempt > is made in the original code either) -- all the more since

Re: [U-Boot] [PATCH v5] Fix board init code to respect the C runtime environment

2015-11-17 Thread Albert ARIBAUD
Hello Simon, On Mon, 16 Nov 2015 21:11:38 -0700, Simon Glass wrote: > > +++ b/arch/arm/lib/crt0.S > > @@ -82,9 +82,11 @@ ENTRY(_main) > > #else > > bic sp, sp, #7 /* 8-byte alignment for ABI compliance */ > > #endif > > + bl board_init_f_get_reserve_size > > +

Re: [U-Boot] [PATCH v5] Fix board init code to respect the C runtime environment

2015-11-16 Thread Simon Glass
Hi Albert, On 16 November 2015 at 09:22, Albert ARIBAUD wrote: > > board_init_f_mem() alters the C runtime environment's > stack it is actually already using. This is not a valid > behaviour within a C runtime environment. > > Split board_init_f_mem into C functions which do not alter > their own

Re: [U-Boot] [PATCH v5] Fix board init code to respect the C runtime environment

2015-11-16 Thread Alexey Brodkin
Hi Albert, On Mon, 2015-11-16 at 17:22 +0100, Albert ARIBAUD wrote: > board_init_f_mem() alters the C runtime environment's > stack it is actually already using. This is not a valid > behaviour within a C runtime environment. > > Split board_init_f_mem into C functions which do not alter > their

[U-Boot] [PATCH v5] Fix board init code to respect the C runtime environment

2015-11-16 Thread Albert ARIBAUD
board_init_f_mem() alters the C runtime environment's stack it is actually already using. This is not a valid behaviour within a C runtime environment. Split board_init_f_mem into C functions which do not alter their own stack and always behave properly with respect to their C runtime environment.