Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-21 Thread Stefano Babic
On 01/20/2011 10:28 PM, Albert ARIBAUD wrote: > Of course I was late to the dance... Stefano, did you rebase your tree? > I still see this patch in your current master. Hi Albert, I have rebased my tree but not pushed on git.denx because I would like to replace the patch with the new version sent

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-20 Thread Albert ARIBAUD
Le 18/01/2011 11:20, Stefano Babic a écrit : > On 01/18/2011 10:24 AM, Wolfgang Denk wrote: > >> It is not too late. I will not pull this into mainline as is. You >> can rebase your tree. > > No problem on my side. Albert should also drop this patch, because it is > already merged into u-boot-arm

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-18 Thread Wolfgang Denk
Dear Jason Liu, In message you wrote: > > ... > >> static table_entry_t imximage_cmds[] = { > >> + {CMD_IMAGE_VERSION, "IMAGE_VERSION","i> mage version", }, > >> {CMD_BOOT_FROM, "BOOT_FROM",> "boot command", }, > >> {CMD_DATA, "DATA",

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-18 Thread stefano babic
Am 18.01.2011 15:59, schrieb Jason Liu: Hi Jason, > > This is the only one patch from the whole pathset(8patches) need get updated > So, I just resubmit it with one newer version for only this patch, is it ok? Yes, I agree. The other patches have received formal ACKs or there are no more commen

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-18 Thread Jason Liu
Hi, Wolfgang, 2011/1/18 Wolfgang Denk : > Dear Jason Liu, > > In message <1294129662-680-7-git-send-email-r64...@freescale.com> you wrote: >> This patch add the MX53 boot image support. >> >> This patch has been tested on Freescale MX53EVK board >> and MX51EVK board. >> >> Signed-off-by: Jason Liu

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-18 Thread Jason Liu
Hi, Wolfgang, 2011/1/18 Wolfgang Denk : > Dear Jason Liu, > > In message you > wrote: >> >> Do I need send out the new version patch for imximage to address >> Wolfgang's comments >> or send out the whole patchset(8patches)  include the new version patch? >> >> What's the process for it? > > If

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-18 Thread Wolfgang Denk
Dear Jason Liu, In message you wrote: > > Do I need send out the new version patch for imximage to address > Wolfgang's comments > or send out the whole patchset(8patches) include the new version patch? > > What's the process for it? If the changes affect only this one patch, then you can re

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-18 Thread Jason Liu
Hi, Wolfgang and Stefano, 2011/1/18 Wolfgang Denk : > Dear Stefano Babic, > > In message <4d353d72.10...@denx.de> you wrote: >> >> it is too late,  it was already pulled. We need now a patch on top of >> this. Jason, can you check Wolfgang's comments and send a patch to fix >> the issues he report

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-18 Thread Stefano Babic
On 01/18/2011 10:24 AM, Wolfgang Denk wrote: > It is not too late. I will not pull this into mainline as is. You > can rebase your tree. No problem on my side. Albert should also drop this patch, because it is already merged into u-boot-arm. I will wait for updates from Jason. Best regards, St

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-18 Thread Wolfgang Denk
Dear Stefano Babic, In message <4d353d72.10...@denx.de> you wrote: > > it is too late, it was already pulled. We need now a patch on top of > this. Jason, can you check Wolfgang's comments and send a patch to fix > the issues he reported ? It is not too late. I will not pull this into mainline

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-17 Thread Stefano Babic
On 01/17/2011 11:54 PM, Wolfgang Denk wrote: > > Stefano, Albert - I apologize for the late review. Please don't pull > this into mainline as is. Wolfgang, it is too late, it was already pulled. We need now a patch on top of this. Jason, can you check Wolfgang's comments and send a patch to fi

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-17 Thread Wolfgang Denk
Dear Jason Liu, In message <1294129662-680-7-git-send-email-r64...@freescale.com> you wrote: > This patch add the MX53 boot image support. > > This patch has been tested on Freescale MX53EVK board > and MX51EVK board. > > Signed-off-by: Jason Liu ... > static table_entry_t imximage_cmds[] = {

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-12 Thread Stefano Babic
On 01/04/2011 09:27 AM, Jason Liu wrote: > This patch add the MX53 boot image support. > > This patch has been tested on Freescale MX53EVK board > and MX51EVK board. > > Signed-off-by: Jason Liu > > --- > Changes for v2: > - Address the following comments from Stefano, > - Get rid of #ifdef

Re: [U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-12 Thread Stefano Babic
On 01/04/2011 09:27 AM, Jason Liu wrote: > This patch add the MX53 boot image support. > > This patch has been tested on Freescale MX53EVK board > and MX51EVK board. > > Signed-off-by: Jason Liu > Tested on vision2 board, too. Tested-by: Stefano Babic Best regards, Stefano Babic -- ==

[U-Boot] [PATCH v4 7/8] imximage: Add MX53 boot image support

2011-01-04 Thread Jason Liu
This patch add the MX53 boot image support. This patch has been tested on Freescale MX53EVK board and MX51EVK board. Signed-off-by: Jason Liu --- Changes for v2: - Address the following comments from Stefano, - Get rid of #ifdef in the imximage.h and .c file and use the runtime check for