Re: [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()

2012-02-15 Thread Simon Glass
Hi Michael, On Wed, Feb 15, 2012 at 11:44 AM, Michael Walle wrote: > Am Mittwoch 15 Februar 2012, 07:05:24 schrieb Simon Glass: >> Unfortunately I think that this approach is a little broken. We are running >> a command sequence from getenv(), but while processing it, we might update >> the envir

Re: [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()

2012-02-15 Thread Michael Walle
Am Mittwoch 15 Februar 2012, 07:05:24 schrieb Simon Glass: > Unfortunately I think that this approach is a little broken. We are running > a command sequence from getenv(), but while processing it, we might update > the environment variable. Worse, we actually overwrite the newlines in the > variab

Re: [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()

2012-02-14 Thread Simon Glass
Hi Michael, On Tue, Feb 14, 2012 at 2:42 PM, Simon Glass wrote: > Hi Michael, > > On Sat, Jan 21, 2012 at 8:07 AM, Michael Walle wrote: > >> >> Hi Simon, >> >> Am Samstag 14 Januar 2012, 07:45:52 schrieb Simon Glass: >> > diff --git a/common/cmd_source.c b/common/cmd_source.c >> > index 481241c

Re: [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()

2012-02-14 Thread Simon Glass
Hi Michael, On Sat, Jan 21, 2012 at 8:07 AM, Michael Walle wrote: > > Hi Simon, > > Am Samstag 14 Januar 2012, 07:45:52 schrieb Simon Glass: > > diff --git a/common/cmd_source.c b/common/cmd_source.c > > index 481241c..32fff5c 100644 > > --- a/common/cmd_source.c > > +++ b/common/cmd_source.c >

Re: [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()

2012-02-14 Thread Simon Glass
Hi Mike, On Sat, Feb 4, 2012 at 7:23 PM, Mike Frysinger wrote: > On Saturday 14 January 2012 01:45:52 Simon Glass wrote: > > This function is only one of the parser options, so use run_command() > > instead. It knows how to use hush if selected. > > i can't grok this either :/ > -mike > Reworde

Re: [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()

2012-02-04 Thread Mike Frysinger
On Saturday 14 January 2012 01:45:52 Simon Glass wrote: > This function is only one of the parser options, so use run_command() > instead. It knows how to use hush if selected. i can't grok this either :/ -mike signature.asc Description: This is a digitally signed message part. _

Re: [U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()

2012-01-21 Thread Michael Walle
Hi Simon, Am Samstag 14 Januar 2012, 07:45:52 schrieb Simon Glass: > diff --git a/common/cmd_source.c b/common/cmd_source.c > index 481241c..32fff5c 100644 > --- a/common/cmd_source.c > +++ b/common/cmd_source.c > @@ -179,7 +179,7 @@ source (ulong addr, const char *fit_uname) >

[U-Boot] [PATCH v4 4/9] Stop using builtin_run_command()

2012-01-13 Thread Simon Glass
This function is only one of the parser options, so use run_command() instead. It knows how to use hush if selected. Signed-off-by: Simon Glass --- arch/arm/cpu/arm926ejs/kirkwood/cpu.c |7 + board/esd/common/auto_update.c|2 +- board/esd/common/cmd_loadpci.c|2 +