Re: [U-Boot] [PATCH v4 4/4] Add USB support for Efika

2011-09-27 Thread Jana Rapava
> Actually I think this is the problem: > writel(ULPI_RWRUN | (u32)reg << ULPI_ADDR_SHIFT, > &ehci->ulpi_viewpoint); > > You cast the u8 * to u32, making the whole first argument of writel() an > u32. > Whereas in the other case, when passing u8, the first argument stays u8 and > the > result

Re: [U-Boot] [PATCH v4 4/4] Add USB support for Efika

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 10:28:17 PM Jana Rapava wrote: > > > + while (--timeout) { > > > + tmp = readl(&ehci->ulpi_viewpoint); > > > + if (!(tmp & ulpi_bit)) > > > + break; > > > + WATCHDOG_RESET(); > > > + } > > > + if (!tim

Re: [U-Boot] [PATCH v4 4/4] Add USB support for Efika

2011-09-26 Thread Marek Vasut
On Monday, September 26, 2011 10:28:17 PM Jana Rapava wrote: > > > + while (--timeout) { > > > + tmp = readl(&ehci->ulpi_viewpoint); > > > + if (!(tmp & ulpi_bit)) > > > + break; > > > + WATCHDOG_RESET(); > > > + } > > > + if (!tim

Re: [U-Boot] [PATCH v4 4/4] Add USB support for Efika

2011-09-26 Thread Jana Rapava
> > + while (--timeout) { > > + tmp = readl(&ehci->ulpi_viewpoint); > > + if (!(tmp & ulpi_bit)) > > + break; > > + WATCHDOG_RESET(); > > + } > > + if (!timeout) { > > + printf("ULPI %s timed out\n", operation); > > +

Re: [U-Boot] [PATCH v4 4/4] Add USB support for Efika

2011-09-25 Thread Marek Vasut
On Sunday, September 25, 2011 07:25:10 PM Jana Rapava wrote: > This commit adds USB support for EfikaMX and EfikaSB. > > Signed-off-by: Jana Rapava > Signed-off-by: Marek Vasut > Cc: Remy Bohmer > Cc: Stefano Babic > --- > Changes for v2: > - changed to proper patch > Changes for v3: >

[U-Boot] [PATCH v4 4/4] Add USB support for Efika

2011-09-25 Thread Jana Rapava
This commit adds USB support for EfikaMX and EfikaSB. Signed-off-by: Jana Rapava Signed-off-by: Marek Vasut Cc: Remy Bohmer Cc: Stefano Babic --- Changes for v2: - changed to proper patch Changes for v3: - merged other USB patches from u-boot-pxa/efikasb - offset-based access