Re: [U-Boot] [PATCH v4 21/24] spi: mxs_spi: Use GENMASK

2015-10-23 Thread Jagan Teki
On 23 October 2015 at 03:00, Marek Vasut wrote: > On Thursday, October 22, 2015 at 11:15:26 PM, Jagan Teki wrote: >> On 23 October 2015 at 02:38, Fabio Estevam wrote: >> > On Thu, Oct 22, 2015 at 6:50 PM, Jagan Teki wrote: >> >> Replace numeric mask hexcodes with GENMASK macro in mxs_spi >> >> >

Re: [U-Boot] [PATCH v4 21/24] spi: mxs_spi: Use GENMASK

2015-10-23 Thread Jagan Teki
On 23 October 2015 at 02:48, Fabio Estevam wrote: > On Thu, Oct 22, 2015 at 7:15 PM, Jagan Teki wrote: > #defineMXS_SPI_MAX_TIMEOUT 100 #defineMXS_SPI_PORT_OFFSET 0x2000 -#define MXS_SSP_CHIPSELECT_MASK0x0030 +#define MXS_SSP_C

Re: [U-Boot] [PATCH v4 21/24] spi: mxs_spi: Use GENMASK

2015-10-22 Thread Marek Vasut
On Thursday, October 22, 2015 at 11:15:26 PM, Jagan Teki wrote: > On 23 October 2015 at 02:38, Fabio Estevam wrote: > > On Thu, Oct 22, 2015 at 6:50 PM, Jagan Teki wrote: > >> Replace numeric mask hexcodes with GENMASK macro in mxs_spi > >> > >> Cc: Marek Vasut > >> Signed-off-by: Jagan Teki >

Re: [U-Boot] [PATCH v4 21/24] spi: mxs_spi: Use GENMASK

2015-10-22 Thread Tom Rini
On Thu, Oct 22, 2015 at 07:08:32PM -0200, Fabio Estevam wrote: > On Thu, Oct 22, 2015 at 6:50 PM, Jagan Teki wrote: > > Replace numeric mask hexcodes with GENMASK macro in mxs_spi > > > > Cc: Marek Vasut > > Signed-off-by: Jagan Teki > > --- > > drivers/spi/mxs_spi.c | 2 +- > > 1 file changed,

Re: [U-Boot] [PATCH v4 21/24] spi: mxs_spi: Use GENMASK

2015-10-22 Thread Fabio Estevam
On Thu, Oct 22, 2015 at 7:15 PM, Jagan Teki wrote: >>> #defineMXS_SPI_MAX_TIMEOUT 100 >>> #defineMXS_SPI_PORT_OFFSET 0x2000 >>> -#define MXS_SSP_CHIPSELECT_MASK0x0030 >>> +#define MXS_SSP_CHIPSELECT_MASKGENMASK(21, 20) >> >> Does t

Re: [U-Boot] [PATCH v4 21/24] spi: mxs_spi: Use GENMASK

2015-10-22 Thread Jagan Teki
On 23 October 2015 at 02:38, Fabio Estevam wrote: > On Thu, Oct 22, 2015 at 6:50 PM, Jagan Teki wrote: >> Replace numeric mask hexcodes with GENMASK macro in mxs_spi >> >> Cc: Marek Vasut >> Signed-off-by: Jagan Teki >> --- >> drivers/spi/mxs_spi.c | 2 +- >> 1 file changed, 1 insertion(+), 1

Re: [U-Boot] [PATCH v4 21/24] spi: mxs_spi: Use GENMASK

2015-10-22 Thread Fabio Estevam
On Thu, Oct 22, 2015 at 6:50 PM, Jagan Teki wrote: > Replace numeric mask hexcodes with GENMASK macro in mxs_spi > > Cc: Marek Vasut > Signed-off-by: Jagan Teki > --- > drivers/spi/mxs_spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/mxs_spi.c b/drivers

[U-Boot] [PATCH v4 21/24] spi: mxs_spi: Use GENMASK

2015-10-22 Thread Jagan Teki
Replace numeric mask hexcodes with GENMASK macro in mxs_spi Cc: Marek Vasut Signed-off-by: Jagan Teki --- drivers/spi/mxs_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c index 627644b..459c603 100644 --- a/drivers/spi/mxs_s