Re: [U-Boot] [PATCH v4 2/2] usb: gadget: add Faraday FOTG210 USB gadget support

2013-05-07 Thread Marek Vasut
Dear Kuo-Jung Su, [...] > > Uh, how's this supposed to work? Why don't you just use mdelay(250) with > > those? > > 1. The CFG_CMD_TIMEOUT is used for polling dma or ep0 fifo ready, > put a permanent delay (i.e. mdelay()) here would slow down the > overall performance. Understood > 2.

Re: [U-Boot] [PATCH v4 2/2] usb: gadget: add Faraday FOTG210 USB gadget support

2013-05-07 Thread Kuo-Jung Su
2013/5/8 Marek Vasut : > Dear Kuo-Jung Su, > >> From: Kuo-Jung Su >> >> The Faraday FOTG210 is an OTG chip which could operate >> as either an EHCI Host or a USB Device as a time. >> >> Signed-off-by: Kuo-Jung Su >> CC: Marek Vasut >> --- >> Changes for v4: >>- Use only macro constants and n

Re: [U-Boot] [PATCH v4 2/2] usb: gadget: add Faraday FOTG210 USB gadget support

2013-05-07 Thread Marek Vasut
Dear Kuo-Jung Su, > From: Kuo-Jung Su > > The Faraday FOTG210 is an OTG chip which could operate > as either an EHCI Host or a USB Device as a time. > > Signed-off-by: Kuo-Jung Su > CC: Marek Vasut > --- > Changes for v4: >- Use only macro constants and named bit/mask >- Remove dcache

[U-Boot] [PATCH v4 2/2] usb: gadget: add Faraday FOTG210 USB gadget support

2013-05-06 Thread Kuo-Jung Su
From: Kuo-Jung Su The Faraday FOTG210 is an OTG chip which could operate as either an EHCI Host or a USB Device as a time. Signed-off-by: Kuo-Jung Su CC: Marek Vasut --- Changes for v4: - Use only macro constants and named bit/mask - Remove dcache_enable() from usb_gadget_register_driver