Re: [U-Boot] [PATCH v4 2/2] ftsdmc021: add register definitions of ftsdmc021

2011-04-26 Thread Macpaul Lin
Hi Wolfgang, 2011/4/26 Wolfgang Denk : > Dear Macpaul Lin, >> +     unsigned int    RSVED[25];      /* 0x3c-0x9c - Reserved         */ > > Sorry, but only macro definitions use ALL CAPS names.  Variables names > are all lower case. > I was think of no used variable will be CAPS names to avoid ty

Re: [U-Boot] [PATCH v4 2/2] ftsdmc021: add register definitions of ftsdmc021

2011-04-26 Thread Wolfgang Denk
Dear Macpaul Lin, In message <1303813524-28948-2-git-send-email-macp...@andestech.com> you wrote: > Support registers definitions of ftsdmc021 SDRAM controller. > > Signed-off-by: Macpaul Lin > --- > Changes for v2: > - Add __ASSEMBLY__ protecton to register offset for supporting lowlevel_init

[U-Boot] [PATCH v4 2/2] ftsdmc021: add register definitions of ftsdmc021

2011-04-26 Thread Macpaul Lin
Support registers definitions of ftsdmc021 SDRAM controller. Signed-off-by: Macpaul Lin --- Changes for v2: - Add __ASSEMBLY__ protecton to register offset for supporting lowlevel_init Changes for v3: - Patch: no change. Changed a mail server to resend this patch Changes for v4: - Cleanup. -