Re: [U-Boot] [PATCH v4 14/27] Introduce generic pre-relocation board_f.c

2012-03-15 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > >> +void coloured_LED_init(void) > >> + __attribute__((weak, alias("__coloured_LED_init"))); > >> +inline void __red_led_on(void) {} > >> +void red_led_on(void) __attribute__((weak, alias("__red_led_on"))); > >> +inline void __red_led_off(void) {}

Re: [U-Boot] [PATCH v4 14/27] Introduce generic pre-relocation board_f.c

2012-03-15 Thread Scott Wood
On 03/15/2012 04:23 PM, Simon Glass wrote: >>> +static int reserve_stacks(void) >>> +{ >>> + /* setup stack pointer for exceptions */ >>> + gd->irq_sp = gd->dest_addr_sp; >>> +#ifdef CONFIG_USE_IRQ >>> + gd->dest_addr_sp -= (CONFIG_STACKSIZE_IRQ + CONFIG_STACKSIZE_FIQ); >>> + debug(

Re: [U-Boot] [PATCH v4 14/27] Introduce generic pre-relocation board_f.c

2012-03-15 Thread Simon Glass
Hi Scott, On Thu, Mar 15, 2012 at 12:09 PM, Scott Wood wrote: > On 03/14/2012 09:16 PM, Simon Glass wrote: >> +/* >> + * sjg: IMO this code should be >> + * refactored to a single function, something like: >> + * >> + * void led_set_state(enum led_colour_t colour, int on); >> + */ >> +/**

Re: [U-Boot] [PATCH v4 14/27] Introduce generic pre-relocation board_f.c

2012-03-15 Thread Scott Wood
On 03/14/2012 09:16 PM, Simon Glass wrote: > +/* > + * sjg: IMO this code should be > + * refactored to a single function, something like: > + * > + * void led_set_state(enum led_colour_t colour, int on); > + */ > +/ > + * Colo

[U-Boot] [PATCH v4 14/27] Introduce generic pre-relocation board_f.c

2012-03-14 Thread Simon Glass
This file handles common pre-relocation init for boards which use the generic framework. It starts up the console, DRAM, performs relocation and then jumps to post-relocation init. Signed-off-by: Simon Glass --- Changes in v3: - Cast away the volatile on gd for memcpy() Changes in v4: - Use asm