Re: [U-Boot] [PATCH v4] usb: kbd: don't fail with iomux

2017-08-08 Thread Bin Meng
Hi Rob, On Tue, Aug 8, 2017 at 6:48 PM, Rob Clark wrote: > On Tue, Aug 8, 2017 at 6:42 AM, Bin Meng wrote: >> Hi Rob, >> >> On Tue, Aug 8, 2017 at 3:51 AM, Rob Clark wrote: >>> stdin might not be set, which would cause iomux_doenv() to fail >>> therefore causing probe_usb_keyboard() to fail. F

Re: [U-Boot] [PATCH v4] usb: kbd: don't fail with iomux

2017-08-08 Thread Rob Clark
On Tue, Aug 8, 2017 at 6:42 AM, Bin Meng wrote: > Hi Rob, > > On Tue, Aug 8, 2017 at 3:51 AM, Rob Clark wrote: >> stdin might not be set, which would cause iomux_doenv() to fail >> therefore causing probe_usb_keyboard() to fail. Furthermore if we do >> have iomux enabled, the sensible thing (in

Re: [U-Boot] [PATCH v4] usb: kbd: don't fail with iomux

2017-08-08 Thread Bin Meng
Hi Rob, On Tue, Aug 8, 2017 at 3:51 AM, Rob Clark wrote: > stdin might not be set, which would cause iomux_doenv() to fail > therefore causing probe_usb_keyboard() to fail. Furthermore if we do > have iomux enabled, the sensible thing (in terms of user experience) > would be to simply add oursel

[U-Boot] [PATCH v4] usb: kbd: don't fail with iomux

2017-08-07 Thread Rob Clark
stdin might not be set, which would cause iomux_doenv() to fail therefore causing probe_usb_keyboard() to fail. Furthermore if we do have iomux enabled, the sensible thing (in terms of user experience) would be to simply add ourselves to the list of stdin devices. This fixes an issue with usbkbd