Hi Igor,
On Sun, Nov 27, 2011 at 12:08 AM, Igor Grinberg wrote:
> Hi Simon,
>
> On 11/27/11 06:00, Simon Glass wrote:
>> Hi Jana,
>>
>> I am interested in this patch. It seems you could tidy the code a
>> litte - sorry if I am too late with comments.
>
> It is never too late, but please consider
2011/11/27 Igor Grinberg
> >
> >> +{
> >> + int timeout = CONFIG_USB_ULPI_TIMEOUT;
> >> + u32 tmp;
> >> +
> >> + writel(ulpi_value, ulpi_viewport);
> >
> > Why do the write here? Should it be done in the write call below? At
> > the very least you should rename this function.
>
2011/11/27 Simon Glass
> > +static int ulpi_wait(u32 ulpi_viewport, u32 ulpi_value, u32 ulpi_mask)
>
>
> How about a comment as to what this function does, params and return
> values?
>
> Also perhaps if you pass the operation to this function it can print
> the error message (perhaps with debug(
Hi Simon,
On 11/27/11 06:00, Simon Glass wrote:
> Hi Jana,
>
> I am interested in this patch. It seems you could tidy the code a
> litte - sorry if I am too late with comments.
It is never too late, but please consider the following:
there are several patch series depending on this one,
so how a
Hi Jana,
I am interested in this patch. It seems you could tidy the code a
litte - sorry if I am too late with comments.
On Fri, Nov 25, 2011 at 12:05 PM, Jana Rapava wrote:
> Add generic functions for ULPI init and setting bits in
> ULPI registers.
>
> Signed-off-by: Jana Rapava
> Cc: Marek Va
Add generic functions for ULPI init and setting bits in
ULPI registers.
Signed-off-by: Jana Rapava
Cc: Marek Vasut
Cc: Remy Bohmer
Cc: Stefano Babic
Cc: Igor Grinberg
Cc: Wolfgang Grandegger
---
Changes for v2:
- make code EHCI-independent
- use udelay() in waiting loop
6 matches
Mail list logo
