Re: [U-Boot] [PATCH v4] serial: uartlite: Support for SERIAL_MULTI

2011-09-21 Thread Mike Frysinger
On Wednesday, September 21, 2011 08:21:35 Michal Simek wrote: > Marek Vasut wrote: > > On Tuesday, September 20, 2011 09:19:23 AM Michal Simek wrote: > >> Michal Simek wrote: > >>> Add support for SERIAL MULTI for uartlite. > >> > >> Any comment? > > > > Avoid endless loops > > No problem to do

Re: [U-Boot] [PATCH v4] serial: uartlite: Support for SERIAL_MULTI

2011-09-21 Thread Michal Simek
Marek Vasut wrote: > On Tuesday, September 20, 2011 09:19:23 AM Michal Simek wrote: >> Michal Simek wrote: >>> Add support for SERIAL MULTI for uartlite. >>> >>> Signed-off-by: Michal Simek >>> >>> --- >>> v2: Use in/out_be32 functions >>> >>> v3: Clean coding style >>> >>> v4: Simplify userial_po

Re: [U-Boot] [PATCH v4] serial: uartlite: Support for SERIAL_MULTI

2011-09-21 Thread Michal Simek
Mike Frysinger wrote: > On Thursday, September 15, 2011 09:50:00 Michal Simek wrote: >> --- a/drivers/serial/serial_xuartlite.c >> +++ b/drivers/serial/serial_xuartlite.c >> >> +static struct uartlite *userial_ports[4] = { > > i think you missed my previous feedback here. pretty sure this should

Re: [U-Boot] [PATCH v4] serial: uartlite: Support for SERIAL_MULTI

2011-09-20 Thread Mike Frysinger
On Thursday, September 15, 2011 09:50:00 Michal Simek wrote: > --- a/drivers/serial/serial_xuartlite.c > +++ b/drivers/serial/serial_xuartlite.c > > +static struct uartlite *userial_ports[4] = { i think you missed my previous feedback here. pretty sure this should be: static struct uartl

Re: [U-Boot] [PATCH v4] serial: uartlite: Support for SERIAL_MULTI

2011-09-20 Thread Marek Vasut
On Tuesday, September 20, 2011 09:19:23 AM Michal Simek wrote: > Michal Simek wrote: > > Add support for SERIAL MULTI for uartlite. > > > > Signed-off-by: Michal Simek > > > > --- > > v2: Use in/out_be32 functions > > > > v3: Clean coding style > > > > v4: Simplify userial_ports array initiali

Re: [U-Boot] [PATCH v4] serial: uartlite: Support for SERIAL_MULTI

2011-09-20 Thread Michal Simek
Michal Simek wrote: > Add support for SERIAL MULTI for uartlite. > > Signed-off-by: Michal Simek > > --- > v2: Use in/out_be32 functions > > v3: Clean coding style > > v4: Simplify userial_ports array initialization > --- > common/serial.c | 14 > drivers/serial/seria

[U-Boot] [PATCH v4] serial: uartlite: Support for SERIAL_MULTI

2011-09-15 Thread Michal Simek
Add support for SERIAL MULTI for uartlite. Signed-off-by: Michal Simek --- v2: Use in/out_be32 functions v3: Clean coding style v4: Simplify userial_ports array initialization --- common/serial.c | 14 drivers/serial/serial_xuartlite.c | 134 +