Re: [U-Boot] [PATCH v4] Gbe Controller driver support for kirkwood SOCs

2009-05-27 Thread Stefan Roese
On Wednesday 27 May 2009 07:26:13 Prafulla Wadaskar wrote: > Thanks a lot Stefan for your review feedback... > You are thinking more similar to Linux Implementation :-) > > I will try to address your suggestions, it provides more flexibility and > readability. On the other hand I am currently putti

Re: [U-Boot] [PATCH v4] Gbe Controller driver support for kirkwood SOCs

2009-05-26 Thread Prafulla Wadaskar
Prabhanjan Sarnaik; Lennert Buijtenhek > Subject: Re: [U-Boot] [PATCH v4] Gbe Controller driver > support for kirkwood SOCs > > Hi Prafulla, > > On Thursday 21 May 2009 22:24:32 Prafulla Wadaskar wrote: > > Contributors: > > Yotam Admon > > Michael Blostein > &g

Re: [U-Boot] [PATCH v4] Gbe Controller driver support for kirkwood SOCs

2009-05-26 Thread Stefan Roese
Hi Prafulla, On Thursday 21 May 2009 22:24:32 Prafulla Wadaskar wrote: > Contributors: > Yotam Admon > Michael Blostein > Reviewed by: Ronen Shitrit > Signed-off-by: Prafulla Wadaskar > --- > Change log: > v2: entire rewrite/restructure of v1 > used small names for variable/function names > re

Re: [U-Boot] [PATCH v4] Gbe Controller driver support for kirkwood SOCs

2009-05-25 Thread Prafulla Wadaskar
Hi Ben Thanks... > > diff --git a/cpu/arm926ejs/kirkwood/cpu.c > > b/cpu/arm926ejs/kirkwood/cpu.c index 1286cac..d37c2e2 100644 > > --- a/cpu/arm926ejs/kirkwood/cpu.c > > +++ b/cpu/arm926ejs/kirkwood/cpu.c > > @@ -314,3 +314,11 @@ int arch_misc_init(void) > > return 0; > > } > > #endif /* C

Re: [U-Boot] [PATCH v4] Gbe Controller driver support for kirkwood SOCs

2009-05-25 Thread Ben Warren
Hi Prafulla, Prafulla Wadaskar wrote: > Contributors: > Yotam Admon > Michael Blostein > Reviewed by: Ronen Shitrit > Signed-off-by: Prafulla Wadaskar > --- > Change log: > v2: entire rewrite/restructure of v1 > used small names for variable/function names > readl/writel used to access SoC reg