Re: [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900

2012-10-16 Thread Pali Rohár
On Tuesday 16 October 2012 17:57:09 Marek Vasut wrote: > > > > > > > + > > > > > > +static unsigned long int twl_wd_time; /* last time > > > > > > of > > > > > > watchdog reset */ +static unsigned long int > > > > > > twl_i2c_lock; > > > > > > > > > > Are you sure you want to use global vars for th

Re: [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900

2012-10-16 Thread Marek Vasut
Dear Pali Rohár, [...] > > > Reason? ++i and i++ are same (for this situation). > > > > On arm, yes, on intel, no in certain cases. Also, to keep the > > code consistent, go with postdecrement. > > What is different on intel (without assigning value of i)? IIRC the prefetch behaves differently

Re: [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900

2012-10-16 Thread Pali Rohár
On Tuesday 16 October 2012 16:55:20 Marek Vasut wrote: > Dear Pali Rohár, > > [...] > > > Nothing. This code must be in assembler because stack is not > > initialized. Also we must be sure that U-Boot will not > > overwrite attached kernel (with can be in U-Boot > > malloc/monitor area...) > Don't

Re: [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900

2012-10-16 Thread Marek Vasut
Dear Pali Rohár, [...] > > Nothing. This code must be in assembler because stack is not > initialized. Also we must be sure that U-Boot will not overwrite > attached kernel (with can be in U-Boot malloc/monitor area...) Don't we have something that can reserve a memory area? > > > +static char

Re: [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900

2012-10-16 Thread Pali Rohár
On Sunday 14 October 2012 02:06:49 Marek Vasut wrote: > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 971235b..613d8cd 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1009,6 +1009,10 @@ Nobuhiro Iwamatsu > > > > > armadillo-800evaR8A7740 (RMOBILE SoC) > > > > +Pali R

Re: [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900

2012-10-15 Thread Ивайло Димитров
Hi Marek, as part of the code is written by me I will answer to a couple of the questions >Dear Pali Rohár, > >> Based on previous work by: Alistair Buxton >> >> Signed-off-by: Pali Rohár >> Cc: Ивайло Димитров > >Can we please stick to ASCII instead of UTF8? > >Cc: Ivaylo Dimitro

Re: [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900

2012-10-14 Thread Albert ARIBAUD
Hi Marek, On Sun, 14 Oct 2012 02:06:49 +0200, Marek Vasut wrote: > Dear Pali Rohár, > > > Based on previous work by: Alistair Buxton > > > > Signed-off-by: Pali Rohár > > Cc: Ивайло Димитров > > Can we please stick to ASCII instead of UTF8? (cc:ing Wolfgang) Not to nitpick too much here

Re: [U-Boot] [PATCH v3 5/5] New board support: Nokia RX-51 aka N900

2012-10-13 Thread Marek Vasut
Dear Pali Rohár, > Based on previous work by: Alistair Buxton > > Signed-off-by: Pali Rohár > Cc: Ивайло Димитров Can we please stick to ASCII instead of UTF8? Cc: Ivaylo Dimitrov (if I'm not mistaken) > --- > Changes since v2: >- Added documentation in doc/README.nokia_rx51 >- Upda