Re: [U-Boot] [PATCH v3 4/4] sandbox: Add basic test for command execution

2012-08-09 Thread Wolfgang Denk
Dear Simon Glass, In message <1333179058-19598-4-git-send-email-...@chromium.org> you wrote: > Since run_command() and run_command_list() are important and a little > confusing, add some basic tests to check that the behaviour is correct. > > Note: I am not sure that this should be committed, nor

Re: [U-Boot] [PATCH v3 4/4] sandbox: Add basic test for command execution

2012-04-08 Thread Mike Frysinger
On Wednesday 04 April 2012 03:18:30 Simon Glass wrote: > On Sun, Apr 1, 2012 at 12:53 PM, Mike Frysinger wrote: > > On Saturday 31 March 2012 03:30:58 Simon Glass wrote: > >> +static int do_ut_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const > > > > what is "ut" supposed to stand for ? > >

Re: [U-Boot] [PATCH v3 4/4] sandbox: Add basic test for command execution

2012-04-04 Thread Simon Glass
Hi Mike, On Sun, Apr 1, 2012 at 12:53 PM, Mike Frysinger wrote: > On Saturday 31 March 2012 03:30:58 Simon Glass wrote: >> --- /dev/null >> +++ b/test/Makefile >> >> +include $(TOPDIR)/config.mk >> + >> +LIB  = $(obj)libtest.o >> + >> +COBJS-$(CONFIG_SANDBOX) += command_ut.o >> + >> +COBJS      

Re: [U-Boot] [PATCH v3 4/4] sandbox: Add basic test for command execution

2012-04-01 Thread Mike Frysinger
On Saturday 31 March 2012 03:30:58 Simon Glass wrote: > --- /dev/null > +++ b/test/Makefile > > +include $(TOPDIR)/config.mk > + > +LIB = $(obj)libtest.o > + > +COBJS-$(CONFIG_SANDBOX) += command_ut.o > + > +COBJS:= $(sort $(COBJS-y)) that sort actually needed ? > +SRCS := $(COBJS:.o=.c)

[U-Boot] [PATCH v3 4/4] sandbox: Add basic test for command execution

2012-03-31 Thread Simon Glass
Since run_command() and run_command_list() are important and a little confusing, add some basic tests to check that the behaviour is correct. Note: I am not sure that this should be committed, nor where it should go in the source tree. Comments welcome. To run the unit tests use the ut_cmd comman