Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files

2016-12-05 Thread Vikas MANOCHA
shberger > ; Kamil Lulko > Subject: RE: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files > > > Hi Vikas, > > On Thu, 1 Dec 2016, Vikas MANOCHA wrote: > > > Thanks Joe for your feedback, > > > >> -Original Message- > >> From: Jo

Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files

2016-12-05 Thread Michael Kurz
; Albert Aribaud ; Joe Hershberger ; Kamil Lulko Subject: Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files On Thu, Dec 1, 2016 at 1:09 PM, Vikas MANOCHA wrote: Hi Joe, -Original Message- From: Joe Hershberger [mailto:joe.hershber...@gmail.com] Sent: Thursday, December 01

Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files

2016-12-01 Thread Vikas MANOCHA
ershberger > ; Kamil Lulko > Subject: Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files > > On Thu, Dec 1, 2016 at 1:09 PM, Vikas MANOCHA wrote: > > Hi Joe, > > > >> -Original Message- > >> From: Joe Hershberger [mailto:joe.hershbe

Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files

2016-12-01 Thread Joe Hershberger
sts.denx.de; Toshifumi >> NISHINAGA ; Albert >> Aribaud ; Joe Hershberger >> ; Kamil Lulko >> Subject: Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files >> >> On Thu, Dec 1, 2016 at 12:18 PM, vikas wrote: >> > Hi Michael, >> > >>

Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files

2016-12-01 Thread Vikas MANOCHA
mil Lulko > Subject: Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files > > On Thu, Dec 1, 2016 at 12:18 PM, vikas wrote: > > Hi Michael, > > > > On 11/24/2016 11:10 AM, Michael Kurz wrote: > >> Cleanup stm32f7 files: > >> - use BIT macro >

Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files

2016-12-01 Thread Joe Hershberger
On Thu, Dec 1, 2016 at 12:18 PM, vikas wrote: > Hi Michael, > > On 11/24/2016 11:10 AM, Michael Kurz wrote: >> Cleanup stm32f7 files: >> - use BIT macro >> - use GENMASK macro > > good. > >> - use rcc struct instead of macro additions > > Macro definitions are better than struct to make rcc compat

Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files

2016-12-01 Thread vikas
Hi Michael, On 11/24/2016 11:10 AM, Michael Kurz wrote: > Cleanup stm32f7 files: > - use BIT macro > - use GENMASK macro good. > - use rcc struct instead of macro additions Macro definitions are better than struct to make rcc compatible throughout the stm32f7 family in case of additional regis

Re: [U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files

2016-11-30 Thread Joe Hershberger
On Thu, Nov 24, 2016 at 1:10 PM, Michael Kurz wrote: > Cleanup stm32f7 files: > - use BIT macro > - use GENMASK macro > - use rcc struct instead of macro additions > > Signed-off-by: Michael Kurz Reviewed-by: Joe Hershberger ___ U-Boot mailing list U-

[U-Boot] [PATCH v3 3/9] ARM: stm32: cleanup stm32f7 files

2016-11-24 Thread Michael Kurz
Cleanup stm32f7 files: - use BIT macro - use GENMASK macro - use rcc struct instead of macro additions Signed-off-by: Michael Kurz --- Changes in v3: - Removed 'prefix all constants with STM32_' - Reverted move of header into source file (rcc.h -> clock.c) Changes in v2: - Add cleanup patch