Re: [U-Boot] [PATCH v3 3/7] dfu: Remove dependency on HUSH parser in SPL

2019-01-23 Thread Andrew F. Davis
On 1/23/19 12:54 AM, Lukasz Majewski wrote: > Hi Tom, > >> On Tue, Jan 22, 2019 at 11:43:33PM +0100, Lukasz Majewski wrote: >>> On Thu, 17 Jan 2019 13:43:04 -0600 >>> "Andrew F. Davis" wrote: >>> CLI support with the HUSH parser is not currently SPL safe due to it's use of realloc. T

Re: [U-Boot] [PATCH v3 3/7] dfu: Remove dependency on HUSH parser in SPL

2019-01-22 Thread Lukasz Majewski
Hi Tom, > On Tue, Jan 22, 2019 at 11:43:33PM +0100, Lukasz Majewski wrote: > > On Thu, 17 Jan 2019 13:43:04 -0600 > > "Andrew F. Davis" wrote: > > > > > CLI support with the HUSH parser is not currently SPL safe due to > > > it's use of realloc. That function is not defined for SPLs that > > >

Re: [U-Boot] [PATCH v3 3/7] dfu: Remove dependency on HUSH parser in SPL

2019-01-22 Thread Tom Rini
On Tue, Jan 22, 2019 at 11:43:33PM +0100, Lukasz Majewski wrote: > On Thu, 17 Jan 2019 13:43:04 -0600 > "Andrew F. Davis" wrote: > > > CLI support with the HUSH parser is not currently SPL safe due to it's > > use of realloc. That function is not defined for SPLs that use > > SYS_MALLOC_SIMPLE. C

Re: [U-Boot] [PATCH v3 3/7] dfu: Remove dependency on HUSH parser in SPL

2019-01-22 Thread Lukasz Majewski
On Thu, 17 Jan 2019 13:43:04 -0600 "Andrew F. Davis" wrote: > CLI support with the HUSH parser is not currently SPL safe due to it's > use of realloc. That function is not defined for SPLs that use > SYS_MALLOC_SIMPLE. CLI support can be built in to SPL and some > functions do work, but use of so

[U-Boot] [PATCH v3 3/7] dfu: Remove dependency on HUSH parser in SPL

2019-01-17 Thread Andrew F. Davis
CLI support with the HUSH parser is not currently SPL safe due to it's use of realloc. That function is not defined for SPLs that use SYS_MALLOC_SIMPLE. CLI support can be built in to SPL and some functions do work, but use of some like run_command() will cause build to fail. When no SPL code calls