Re: [U-Boot] [PATCH v3 21/22] ide: Correct function signatures for ide_read/write()

2012-10-29 Thread Simon Glass
Hi, On Mon, Oct 29, 2012 at 11:22 AM, Tom Rini wrote: > On Mon, Oct 29, 2012 at 08:24:04AM -0700, Simon Glass wrote: > >> The prototypes in the header were changed by commit 4ac8f8e0 but the >> functions no longer match. Correct this. > > Oops, not sure how I missed that. > >> It seems odd that b

Re: [U-Boot] [PATCH v3 21/22] ide: Correct function signatures for ide_read/write()

2012-10-29 Thread Tom Rini
On Mon, Oct 29, 2012 at 08:24:04AM -0700, Simon Glass wrote: > The prototypes in the header were changed by commit 4ac8f8e0 but the > functions no longer match. Correct this. Oops, not sure how I missed that. > It seems odd that block devices take an lbaint_t for the block count, but > an unsign

[U-Boot] [PATCH v3 21/22] ide: Correct function signatures for ide_read/write()

2012-10-29 Thread Simon Glass
The prototypes in the header were changed by commit 4ac8f8e0 but the functions no longer match. Correct this. It seems odd that block devices take an lbaint_t for the block count, but an unsigned long for the blknr. Surely we should promote blknr to lbaint_t also? Signed-off-by: Simon Glass ---