Re: [U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

2014-08-07 Thread Marek Vasut
On Thursday, August 07, 2014 at 06:52:44 PM, Steve Rae wrote: [...] > >> I was referring to what you mention below... > >> > >>852 - Safe printf() functions > >>853 Define CONFIG_SYS_VSNPRINTF to compile in safe versions of > >>854 the printf() functions. These are defined

Re: [U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

2014-08-07 Thread Steve Rae
On 14-08-07 06:23 AM, Marek Vasut wrote: On Thursday, August 07, 2014 at 02:28:13 AM, Steve Rae wrote: On 14-08-06 05:13 PM, Marek Vasut wrote: On Thursday, August 07, 2014 at 01:48:06 AM, Steve Rae wrote: On 14-07-30 06:37 PM, Marek Vasut wrote: On Thursday, June 26, 2014 at 10:13:22 PM, S

Re: [U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

2014-08-07 Thread Marek Vasut
On Thursday, August 07, 2014 at 03:28:14 PM, Pantelis Antoniou wrote: > Hi Marek, > > [snip] > > >> I don't want to be the first to defined it for all of armv7 > > > > Honestly, we should just enable this CONFIG_SYS_VSNPRINTF by default for > > the good of humanity and all the things, since

Re: [U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

2014-08-07 Thread Pantelis Antoniou
Hi Marek, [snip] >> I don't want to be the first to defined it for all of armv7 > > Honestly, we should just enable this CONFIG_SYS_VSNPRINTF by default for the > good of humanity and all the things, since this unbounded string handling is > just evil (see how OpenSSL ended up, partly beca

Re: [U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

2014-08-07 Thread Marek Vasut
On Thursday, August 07, 2014 at 02:28:13 AM, Steve Rae wrote: > On 14-08-06 05:13 PM, Marek Vasut wrote: > > On Thursday, August 07, 2014 at 01:48:06 AM, Steve Rae wrote: > >> On 14-07-30 06:37 PM, Marek Vasut wrote: > >>> On Thursday, June 26, 2014 at 10:13:22 PM, Steve Rae wrote: > >>> [...] > >>

Re: [U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

2014-08-06 Thread Steve Rae
On 14-08-06 05:13 PM, Marek Vasut wrote: On Thursday, August 07, 2014 at 01:48:06 AM, Steve Rae wrote: On 14-07-30 06:37 PM, Marek Vasut wrote: On Thursday, June 26, 2014 at 10:13:22 PM, Steve Rae wrote: [...] + +#include +#include +#include +#include + +/* The 64 defined bytes plus \0

Re: [U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

2014-08-06 Thread Marek Vasut
On Thursday, August 07, 2014 at 01:48:06 AM, Steve Rae wrote: > On 14-07-30 06:37 PM, Marek Vasut wrote: > > On Thursday, June 26, 2014 at 10:13:22 PM, Steve Rae wrote: > > [...] > > > >> + > >> +#include > >> +#include > >> +#include > >> +#include > >> + > >> +/* The 64 defined bytes plus \0

Re: [U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

2014-08-06 Thread Steve Rae
On 14-07-30 06:37 PM, Marek Vasut wrote: On Thursday, June 26, 2014 at 10:13:22 PM, Steve Rae wrote: [...] + +#include +#include +#include +#include + +/* The 64 defined bytes plus \0 */ +#define RESPONSE_LEN (64 + 1) + +static char *response_str; I'd suggest to pass this "response_str

Re: [U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

2014-07-30 Thread Marek Vasut
On Thursday, June 26, 2014 at 10:13:22 PM, Steve Rae wrote: [...] > + > +#include > +#include > +#include > +#include > + > +/* The 64 defined bytes plus \0 */ > +#define RESPONSE_LEN (64 + 1) > + > +static char *response_str; I'd suggest to pass this "response_str" around instead of making it

[U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

2014-06-26 Thread Steve Rae
- add support for 'fastboot flash' command for eMMC devices Signed-off-by: Steve Rae --- I suspect that the "sparse image" handling (ie. the "while (remaining_chunks)" loop) has been implemented elsewhere -- I need help finding the original code to determine any licensing issues Thanks, Ste