Re: [U-Boot] [PATCH v3 2/2] ventana: Add Gateworks Ventana family support

2014-02-09 Thread Tim Harvey
On Thu, Feb 6, 2014 at 4:07 AM, Wolfgang Denk wrote: > Dear Tim, > > In message > you > wrote: >> >> > > +/* >> > > + * Hardware Monitor >> > > + */ >> > > +#define GSC_HWMON_TEMP 0x00 >> > > +#define GSC_HWMON_VIN0x02 >> > > +#define GSC_HWMON_VDD_3P30x05 >> >

Re: [U-Boot] [PATCH v3 2/2] ventana: Add Gateworks Ventana family support

2014-02-06 Thread Tom Rini
On Thu, Feb 06, 2014 at 01:07:44PM +0100, Wolfgang Denk wrote: > Dear Tim, > > In message > you > wrote: [snip] > > > This causes a checkpatch error: > > > > > > ERROR: Macros with complex values should be enclosed in parenthesis > > > > > > Please fix! > > > > what args do you run checkpatch.

Re: [U-Boot] [PATCH v3 2/2] ventana: Add Gateworks Ventana family support

2014-02-06 Thread Wolfgang Denk
Dear Tim, In message you wrote: > > > > +/* > > > + * Hardware Monitor > > > + */ > > > +#define GSC_HWMON_TEMP 0x00 > > > +#define GSC_HWMON_VIN0x02 > > > +#define GSC_HWMON_VDD_3P30x05 > > > +#define GSC_HWMON_VBATT 0x08 > > > +#define GSC_HWMON_V

Re: [U-Boot] [PATCH v3 2/2] ventana: Add Gateworks Ventana family support

2014-02-05 Thread Tim Harvey
On Wed, Feb 5, 2014 at 3:43 PM, Wolfgang Denk wrote: > > Dear Tim Harvey, > > In message <1391642553-25778-1-git-send-email-thar...@gateworks.com> you > wrote: > > Gateworks Ventana is a product family based on the i.MX6. This > > patch adds support for all boards in the Ventana family. Where >

Re: [U-Boot] [PATCH v3 2/2] ventana: Add Gateworks Ventana family support

2014-02-05 Thread Wolfgang Denk
Dear Tim Harvey, In message <1391642553-25778-1-git-send-email-thar...@gateworks.com> you wrote: > Gateworks Ventana is a product family based on the i.MX6. This > patch adds support for all boards in the Ventana family. Where > possible, data from the boards EEPROM is used to determine various >