Re: [U-Boot] [PATCH v3 2/2] ftsdmc021: add register definitions of ftsdmc021

Hi Wolfgang, 2011/4/26 Wolfgang Denk : > Dear Macpaul Lin, >> +#define FTSDMC021_OFFSET_BANK7_BSR   0x2C    /* External Bank Base/Size Reg >> 7 */ > > Lines too long.  Please fix globally. > > I think it is generally wrong to manually define these offsets here. > You should use a C struct instead

Re: [U-Boot] [PATCH v3 2/2] ftsdmc021: add register definitions of ftsdmc021

Dear Macpaul Lin, In message <1303797876-28548-2-git-send-email-macp...@andestech.com> you wrote: > Support registers definitions of ftsdmc021 SDRAM controller. > > Signed-off-by: Macpaul Lin > --- > Changes for v2: > - Add __ASSEMBLY__ protecton to register offset for supporting lowlevel_init

[U-Boot] [PATCH v3 2/2] ftsdmc021: add register definitions of ftsdmc021

Support registers definitions of ftsdmc021 SDRAM controller. Signed-off-by: Macpaul Lin --- Changes for v2: - Add __ASSEMBLY__ protecton to register offset for supporting lowlevel_init Changes for v3: - Patch: no change. Changed a mail server to resend this. include/faraday/ftsdmc021.h | 154