Re: [U-Boot] [PATCH v3 2/2] env: mmc: add erase-function

2019-04-26 Thread Simon Goldschmidt
On Fri, Apr 26, 2019 at 5:18 PM Frank Wunderlich wrote: > > Hi Simon > > thanks for your review.. > > > > + if (!mmc) > > > + return CMD_RET_FAILURE; > > > + > > > + blk = CONFIG_ENV_OFFSET / mmc->read_bl_len; > > > + cnt = CONFIG_ENV_SIZE / mmc->read_bl_len; > > >

Re: [U-Boot] [PATCH v3 2/2] env: mmc: add erase-function

2019-04-26 Thread Frank Wunderlich
Hi Simon thanks for your review.. > > + if (!mmc) > > + return CMD_RET_FAILURE; > > + > > + blk = CONFIG_ENV_OFFSET / mmc->read_bl_len; > > + cnt = CONFIG_ENV_SIZE / mmc->read_bl_len; > > Hmm, this doesn't work with redundant env. To fix this, you probably > need t

Re: [U-Boot] [PATCH v3 2/2] env: mmc: add erase-function

2019-04-25 Thread Simon Goldschmidt
On Fri, Apr 12, 2019 at 11:38 AM Frank Wunderlich wrote: > Missing description here. I just saw I forgot this comment for the 1/2 patch, too. There's no description there as well. > Signed-off-by: Frank Wunderlich > --- > env/mmc.c | 28 > 1 file changed, 28 insert

[U-Boot] [PATCH v3 2/2] env: mmc: add erase-function

2019-04-12 Thread Frank Wunderlich
Signed-off-by: Frank Wunderlich --- env/mmc.c | 28 1 file changed, 28 insertions(+) diff --git a/env/mmc.c b/env/mmc.c index c3cf35d01b..f387a53970 100644 --- a/env/mmc.c +++ b/env/mmc.c @@ -242,6 +242,33 @@ fini: fini_mmc_for_env(mmc); return ret;