Re: [U-Boot] [PATCH v3 1/4] Add run_command_list() to run a list of commands

2012-08-09 Thread Wolfgang Denk
Dear Simon Glass, In message <1333179058-19598-1-git-send-email-...@chromium.org> you wrote: > This new function runs a list of commands separated by semicolon or newline. > We move this out of cmd_source so that it can be used by other code. The > PXE code also uses the new function. > > Suggest

Re: [U-Boot] [PATCH v3 1/4] Add run_command_list() to run a list of commands

2012-04-08 Thread Simon Glass
Hi Mike, On Sun, Apr 8, 2012 at 1:39 AM, Mike Frysinger wrote: > On Wednesday 04 April 2012 03:12:27 Simon Glass wrote: >> On Sun, Apr 1, 2012 at 12:48 PM, Mike Frysinger wrote: >> > On Saturday 31 March 2012 03:30:55 Simon Glass wrote: >> >> --- a/common/cmd_pxe.c >> >> +++ b/common/cmd_pxe.c >>

Re: [U-Boot] [PATCH v3 1/4] Add run_command_list() to run a list of commands

2012-04-08 Thread Mike Frysinger
On Wednesday 04 April 2012 03:12:27 Simon Glass wrote: > On Sun, Apr 1, 2012 at 12:48 PM, Mike Frysinger wrote: > > On Saturday 31 March 2012 03:30:55 Simon Glass wrote: > >> --- a/common/cmd_pxe.c > >> +++ b/common/cmd_pxe.c > >> > >> +int run_command_list(const char *cmd, int len, int flag) > >>

Re: [U-Boot] [PATCH v3 1/4] Add run_command_list() to run a list of commands

2012-04-04 Thread Simon Glass
Hi Mike, On Sun, Apr 1, 2012 at 12:48 PM, Mike Frysinger wrote: > On Saturday 31 March 2012 03:30:55 Simon Glass wrote: >> --- a/common/cmd_pxe.c >> +++ b/common/cmd_pxe.c >> >> +     return run_command_list(localcmd, strlen(localcmd), 0); > > should be -1 instead of strlen() done > >> +int run

Re: [U-Boot] [PATCH v3 1/4] Add run_command_list() to run a list of commands

2012-04-01 Thread Mike Frysinger
On Saturday 31 March 2012 03:30:55 Simon Glass wrote: > --- a/common/cmd_pxe.c > +++ b/common/cmd_pxe.c > > + return run_command_list(localcmd, strlen(localcmd), 0); should be -1 instead of strlen() > +int run_command_list(const char *cmd, int len, int flag) > +{ > + int need_buff = 1; >

[U-Boot] [PATCH v3 1/4] Add run_command_list() to run a list of commands

2012-03-31 Thread Simon Glass
This new function runs a list of commands separated by semicolon or newline. We move this out of cmd_source so that it can be used by other code. The PXE code also uses the new function. Suggested-by: Michael Walle Signed-off-by: Simon Glass --- Changes in v3: - Added a few more comments on the