Re: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-29 Thread Ajay Bhargav
- "Mike Frysinger" wrote: > On Monday, August 29, 2011 01:39:18 Ajay Bhargav wrote: > > - "Mike Frysinger" wrote: > > > On Monday, August 29, 2011 01:10:49 Ajay Bhargav wrote: > > > > - "Mike Frysinger" wrote: > > > > > On Friday, August 26, 2011 02:36:51 Ajay Bhargav wrote: > > >

Re: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-29 Thread Mike Frysinger
On Monday, August 29, 2011 01:39:18 Ajay Bhargav wrote: > - "Mike Frysinger" wrote: > > On Monday, August 29, 2011 01:10:49 Ajay Bhargav wrote: > > > - "Mike Frysinger" wrote: > > > > On Friday, August 26, 2011 02:36:51 Ajay Bhargav wrote: > > > > > +darmdfec = malloc(sizeof(struc

Re: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-29 Thread Marek Vasut
On Monday, August 29, 2011 07:39:18 AM Ajay Bhargav wrote: > - "Mike Frysinger" wrote: > > On Monday, August 29, 2011 01:10:49 Ajay Bhargav wrote: > > > - "Mike Frysinger" wrote: > > > > On Friday, August 26, 2011 02:36:51 Ajay Bhargav wrote: > > > > > +darmdfec = malloc(sizeof(st

Re: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-28 Thread Ajay Bhargav
- "Mike Frysinger" wrote: > On Monday, August 29, 2011 01:10:49 Ajay Bhargav wrote: > > - "Mike Frysinger" wrote: > > > On Friday, August 26, 2011 02:36:51 Ajay Bhargav wrote: > > > > +darmdfec = malloc(sizeof(struct armdfec_device)); > > > > +if (!darmdfec) > > > > +

Re: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-28 Thread Ajay Bhargav
- "Marek Vasut" wrote: > On Friday, August 26, 2011 08:36:51 AM Ajay Bhargav wrote: > > This patch adds support for Fast Ethernet Controller driver for > > Armada100 series. > > > > Signed-off-by: Ajay Bhargav > > Hi, please don't forget to CC me next time ;-) > Sure, I'll do that.. you

Re: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-28 Thread Mike Frysinger
On Monday, August 29, 2011 01:10:49 Ajay Bhargav wrote: > - "Mike Frysinger" wrote: > > On Friday, August 26, 2011 02:36:51 Ajay Bhargav wrote: > > > +darmdfec = malloc(sizeof(struct armdfec_device)); > > > +if (!darmdfec) > > > +goto error; > > > > if this fir

Re: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-28 Thread Ajay Bhargav
- "Mike Frysinger" wrote: > On Friday, August 26, 2011 02:36:51 Ajay Bhargav wrote: > > +static int add_del_hash_entry(struct armdfec_device *darmdfec, u32 > mach, > > + u32 macl, u32 rd, u32 skip, int del) > > +{ > > +u8 *last; > > local var ... > > >

Re: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-26 Thread Mike Frysinger
On Friday, August 26, 2011 02:36:51 Ajay Bhargav wrote: > +static int add_del_hash_entry(struct armdfec_device *darmdfec, u32 mach, > + u32 macl, u32 rd, u32 skip, int del) > +{ > + u8 *last; local var ... > + last = (u8 *) entry; > + last = last + sizeof(*en

Re: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-26 Thread Marek Vasut
On Friday, August 26, 2011 08:36:51 AM Ajay Bhargav wrote: > This patch adds support for Fast Ethernet Controller driver for > Armada100 series. > > Signed-off-by: Ajay Bhargav Hi, please don't forget to CC me next time ;-) [...] > +static int smi_reg_read(const char *devname, u8 phy_addr, u8

[U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100

2011-08-25 Thread Ajay Bhargav
This patch adds support for Fast Ethernet Controller driver for Armada100 series. Signed-off-by: Ajay Bhargav --- Changes for v2: - removed random MAC generation - driver init function changed to register as per new naming convention - code cleanup (Thanks to Wolfgang, Mar