Re: [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support

2010-09-09 Thread Feng Kan
On Thu, Sep 9, 2010 at 10:39 AM, Stefan Roese wrote: > Hi Marri, > > On Thursday 09 September 2010 18:43:31 Tirumala Marri wrote: >> > It makes no sense to duplicate common parts. Only different code >> > should be moved to separate files. >> >> [Marri] It is only few lines of code is different. A

Re: [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support

2010-09-09 Thread Tirumala Marri
Stefan, > > Please wait a day or two. I have an idea on how to best cleanup this > PPC4xx > header mess and will post some patches for it soon. It would be best if > you > could rebase your work on those patches then (if we find a consensus > here). Sure I will wait for your changes. Regards, M

Re: [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support

2010-09-09 Thread Stefan Roese
Hi Marri, On Thursday 09 September 2010 18:43:31 Tirumala Marri wrote: > > It makes no sense to duplicate common parts. Only different code > > should be moved to separate files. > > [Marri] It is only few lines of code is different. Any way I will make a > change and Send it. Please wait a day

Re: [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support

2010-09-09 Thread Tirumala Marri
> > > include/apm821xx.h | 493 > +++ > > > > I know that Wolfgang specifically asked you to add this file for this > > "new" SoC. But I'm not so sure if this is the right way. Most of the > > defines in this new file are a plain copy from include/p

Re: [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support

2010-09-09 Thread Wolfgang Denk
Dear Stefan Roese, In message <201009091645.16076...@denx.de> you wrote: > > > include/apm821xx.h | 493 > > +++ > > I know that Wolfgang specifically asked you to add this file for this > "new" SoC. But I'm not so sure if this is the right way.

Re: [U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support

2010-09-09 Thread Stefan Roese
Hi Marri, On Wednesday 08 September 2010 04:06:21 tma...@apm.com wrote: > From: Tirumala Marri > > APM821XX is a new line of SoCs which are derivatives of > PPC44X family of processors. This patch adds support of CPU, cache, > tlb, 32k ocm, bootstraps, PLB and AHB bus. Look mostly good. One com

[U-Boot] [PATCH v3 1/2] APM821xx: Add CPU support

2010-09-07 Thread tmarri
From: Tirumala Marri APM821XX is a new line of SoCs which are derivatives of PPC44X family of processors. This patch adds support of CPU, cache, tlb, 32k ocm, bootstraps, PLB and AHB bus. Signed-off-by: Tirumala R Marri --- V2: * Removed Defines added to 405ex. V3: * Change APM82XXX to AP