Re: [U-Boot] [PATCH v3 1/1] gpio: altera_pio: fix get_value

2019-02-20 Thread Marek Vasut
On 2/20/19 4:13 PM, Julien Béraud wrote: > > On 07/01/2019 10:27, Julien Beraud wrote: >> >> On 07/01/2019 10:26, Marek Vasut wrote: >> >>> btw. you should keep a changelog with each new Vx of a patch. >>> Here it's fine, just add one next time you submit patches. >> Sure, I'll do it next time. Th

Re: [U-Boot] [PATCH v3 1/1] gpio: altera_pio: fix get_value

2019-02-20 Thread Julien Béraud
On 07/01/2019 10:27, Julien Beraud wrote: > > On 07/01/2019 10:26, Marek Vasut wrote: > >> btw. you should keep a changelog with each new Vx of a patch. >> Here it's fine, just add one next time you submit patches. > Sure, I'll do it next time. Thanks. > > Julien Hi Marek, I can see on https:

Re: [U-Boot] [PATCH v3 1/1] gpio: altera_pio: fix get_value

2019-01-07 Thread Julien Béraud
On 07/01/2019 10:26, Marek Vasut wrote: > btw. you should keep a changelog with each new Vx of a patch. > Here it's fine, just add one next time you submit patches. Sure, I'll do it next time. Thanks. Julien ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH v3 1/1] gpio: altera_pio: fix get_value

2019-01-07 Thread Marek Vasut
On 1/7/19 10:17 AM, Julien Béraud wrote: > gpio_get_value should return 0 or 1, not the value of bit & (1 << pin) > > Acked-by: Marek Vasut > Signed-off-by: Julien Beraud btw. you should keep a changelog with each new Vx of a patch. Here it's fine, just add one next time you submit patches. >

[U-Boot] [PATCH v3 1/1] gpio: altera_pio: fix get_value

2019-01-07 Thread Julien Béraud
gpio_get_value should return 0 or 1, not the value of bit & (1 << pin) Acked-by: Marek Vasut Signed-off-by: Julien Beraud --- drivers/gpio/altera_pio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/altera_pio.c b/drivers/gpio/altera_pio.c index 59e30979f0..324