Re: [U-Boot] [PATCH v3] sandbox: fix compiler warning

2013-02-15 Thread Simon Glass
On Thu, Jan 24, 2013 at 4:45 AM, Albert ARIBAUD wrote: > Hi Allen, > > On Wed, 23 Jan 2013 13:05:27 -0800, Allen Martin > wrote: > >> > Shouldn't the function be given '__attribute__((noreturn))' rather than >> > adding a non-executed 'return 0' to it? >> > >> >> The function in question is sandb

Re: [U-Boot] [PATCH v3] sandbox: fix compiler warning

2013-01-24 Thread Albert ARIBAUD
Hi Allen, On Wed, 23 Jan 2013 13:05:27 -0800, Allen Martin wrote: > > Shouldn't the function be given '__attribute__((noreturn))' rather than > > adding a non-executed 'return 0' to it? > > > > The function in question is sandbox main(), and it can return if there > was an error prior to calli

Re: [U-Boot] [PATCH v3] sandbox: fix compiler warning

2013-01-23 Thread Allen Martin
On Tue, Jan 22, 2013 at 10:46:03PM -0800, Albert ARIBAUD wrote: > Hi Allen, > > On Tue, 22 Jan 2013 15:11:21 -0800, Allen Martin > wrote: > > > Add back return statement to fix compiler warning about control flow > > reaching end of non void function that was introduced with: > > > > e05e5d

Re: [U-Boot] [PATCH v3] sandbox: fix compiler warning

2013-01-22 Thread Albert ARIBAUD
Hi Allen, On Tue, 22 Jan 2013 15:11:21 -0800, Allen Martin wrote: > Add back return statement to fix compiler warning about control flow > reaching end of non void function that was introduced with: > > e05e5de arm: move C runtime setup code in crt0.S > > Signed-off-by: Allen Martin > A

[U-Boot] [PATCH v3] sandbox: fix compiler warning

2013-01-22 Thread Allen Martin
Add back return statement to fix compiler warning about control flow reaching end of non void function that was introduced with: e05e5de arm: move C runtime setup code in crt0.S Signed-off-by: Allen Martin Acked-by: Simon Glass --- arch/sandbox/cpu/start.c |3 +++ 1 file changed, 3