Re: [U-Boot] [PATCH v3] mx25: Clean up lowlevel_init

2012-10-02 Thread Stefano Babic
On 20/08/2012 21:00, Benoît Thébaudeau wrote: > Clean up mx25 lowlevel_init: > - Add comments. > - Do not use write32 repeatedly with the same value in order not to increase >code size. > - Make register values configurable. > - Use macro parameters with default values instead of literal co

Re: [U-Boot] [PATCH v3] mx25: Clean up lowlevel_init

2012-10-02 Thread Stefano Babic
On 01/10/2012 21:50, Benoît Thébaudeau wrote: > Hi Stefano, > > On Sunday, September 30, 2012 3:47:12 PM, Benoît Thébaudeau wrote: >> Hi Stefano, >> >> On Sunday, September 30, 2012 3:04:14 PM, Stefano Babic wrote: >>> On 20/08/2012 21:00, Benoît Thébaudeau wrote: Clean up mx25 lowlevel_init:

Re: [U-Boot] [PATCH v3] mx25: Clean up lowlevel_init

2012-10-01 Thread Benoît Thébaudeau
Hi Stefano, On Sunday, September 30, 2012 3:47:12 PM, Benoît Thébaudeau wrote: > Hi Stefano, > > On Sunday, September 30, 2012 3:04:14 PM, Stefano Babic wrote: > > On 20/08/2012 21:00, Benoît Thébaudeau wrote: > > > Clean up mx25 lowlevel_init: > > > - Add comments. > > > - Do not use write32 r

Re: [U-Boot] [PATCH v3] mx25: Clean up lowlevel_init

2012-09-30 Thread Benoît Thébaudeau
Hi Stefano, On Sunday, September 30, 2012 3:04:14 PM, Stefano Babic wrote: > On 20/08/2012 21:00, Benoît Thébaudeau wrote: > > Clean up mx25 lowlevel_init: > > - Add comments. > > - Do not use write32 repeatedly with the same value in order not > > to increase > >code size. > > - Make regi

Re: [U-Boot] [PATCH v3] mx25: Clean up lowlevel_init

2012-09-30 Thread Stefano Babic
On 20/08/2012 21:00, Benoît Thébaudeau wrote: > Clean up mx25 lowlevel_init: > - Add comments. > - Do not use write32 repeatedly with the same value in order not to increase >code size. > - Make register values configurable. > - Use macro parameters with default values instead of literal co

[U-Boot] [PATCH v3] mx25: Clean up lowlevel_init

2012-08-20 Thread Benoît Thébaudeau
Clean up mx25 lowlevel_init: - Add comments. - Do not use write32 repeatedly with the same value in order not to increase code size. - Make register values configurable. - Use macro parameters with default values instead of literal constants. - Use defined macros instead of duplicating code