Re: [U-Boot] [PATCH v3] mmc-uclass: correct the device number

2016-07-31 Thread Simon Glass
Hi Jaehoon, On 21 July 2016 at 22:14, Jaehoon Chung wrote: > Hi Simon, > > On 07/22/2016 12:21 PM, Simon Glass wrote: >> Hi Kever, >> >> On 19 July 2016 at 07:28, Kever Yang wrote: >>> Not like the mmc-legacy which the devnum starts from 1, it starts from 0 >>> in mmc-uclass, so the device numbe

Re: [U-Boot] [PATCH v3] mmc-uclass: correct the device number

2016-07-21 Thread Jaehoon Chung
Hi Simon, On 07/22/2016 12:21 PM, Simon Glass wrote: > Hi Kever, > > On 19 July 2016 at 07:28, Kever Yang wrote: >> Not like the mmc-legacy which the devnum starts from 1, it starts from 0 >> in mmc-uclass, so the device number should be (devnum + 1) in get_mmc_num(). >> >> Signed-off-by: Kever

Re: [U-Boot] [PATCH v3] mmc-uclass: correct the device number

2016-07-21 Thread Simon Glass
Hi Kever, On 19 July 2016 at 07:28, Kever Yang wrote: > Not like the mmc-legacy which the devnum starts from 1, it starts from 0 > in mmc-uclass, so the device number should be (devnum + 1) in get_mmc_num(). > > Signed-off-by: Kever Yang > --- > > Changes in v3: > - apply comments from Jaehoon C

Re: [U-Boot] [PATCH v3] mmc-uclass: correct the device number

2016-07-20 Thread Jaehoon Chung
Hi Kever, On 07/19/2016 10:28 PM, Kever Yang wrote: > Not like the mmc-legacy which the devnum starts from 1, it starts from 0 > in mmc-uclass, so the device number should be (devnum + 1) in get_mmc_num(). Looks good to me. I had already sent the similar patch for this. (http://patchwork.ozlabs.o

[U-Boot] [PATCH v3] mmc-uclass: correct the device number

2016-07-19 Thread Kever Yang
Not like the mmc-legacy which the devnum starts from 1, it starts from 0 in mmc-uclass, so the device number should be (devnum + 1) in get_mmc_num(). Signed-off-by: Kever Yang --- Changes in v3: - apply comments from Jaehoon Chung Changes in v2: - add comment for get_mmc_num() in mmc.h - update