Re: [U-Boot] [PATCH v3] arm926ejs: timer: Replace bss variable by gdr

2011-01-23 Thread Heiko Schocher
Hello Alexander, Alexander Holler wrote: > Am 22.01.2011 08:46, schrieb Albert ARIBAUD: >> Le 22/01/2011 06:39, Alexander Holler a écrit : >>> Hello, >>> >>> Am 21.01.2011 09:56, schrieb Heiko Schocher: >>> -static ulong timestamp; -static ulong lastdec; +DECLARE_GLOBAL_DATA_PTR; >>

Re: [U-Boot] [PATCH v3] arm926ejs: timer: Replace bss variable by gdr

2011-01-22 Thread Alexander Holler
Am 22.01.2011 08:46, schrieb Albert ARIBAUD: > Le 22/01/2011 06:39, Alexander Holler a écrit : >> Hello, >> >> Am 21.01.2011 09:56, schrieb Heiko Schocher: >> >>> -static ulong timestamp; >>> -static ulong lastdec; >>> +DECLARE_GLOBAL_DATA_PTR; >>> + >>> +#define timestamp gd->tbl >>> +#define last

Re: [U-Boot] [PATCH v3] arm926ejs: timer: Replace bss variable by gdr

2011-01-22 Thread Reinhard Meyer
Dear Albert ARIBAUD, > However a general rework of ARM timer code is in order so that all SoCs > and CPUs share the same set of gd variables with the same names and the > same logic; and when we get that, this code shall move along. > > About this rework, as the saying goes... "Patches Welcome ©".

Re: [U-Boot] [PATCH v3] arm926ejs: timer: Replace bss variable by gdr

2011-01-21 Thread Albert ARIBAUD
Le 22/01/2011 06:39, Alexander Holler a écrit : > Hello, > > Am 21.01.2011 09:56, schrieb Heiko Schocher: > >> -static ulong timestamp; >> -static ulong lastdec; >> +DECLARE_GLOBAL_DATA_PTR; >> + >> +#define timestamp gd->tbl >> +#define lastdec gd->lastinc > > I'm the only one who doesn't like suc

Re: [U-Boot] [PATCH v3] arm926ejs: timer: Replace bss variable by gdr

2011-01-21 Thread Alexander Holler
Hello, Am 21.01.2011 09:56, schrieb Heiko Schocher: > -static ulong timestamp; > -static ulong lastdec; > +DECLARE_GLOBAL_DATA_PTR; > + > +#define timestamp gd->tbl > +#define lastdec gd->lastinc I'm the only one who doesn't like such defines? They might be handy for quick fixes, but in regard

Re: [U-Boot] [PATCH v3] arm926ejs: timer: Replace bss variable by gdr

2011-01-21 Thread Albert ARIBAUD
Hi Heiko, Le 21/01/2011 09:56, Heiko Schocher a écrit : > Reuse the gd->tbl value for timestamp and add gd->lastinc for lastinc bss > values in the arm926ejs timers implementation. > > The usage of bss values in drivers before initialisation of bss is forbidden. > In that special case some data in

[U-Boot] [PATCH v3] arm926ejs: timer: Replace bss variable by gdr

2011-01-21 Thread Heiko Schocher
Reuse the gd->tbl value for timestamp and add gd->lastinc for lastinc bss values in the arm926ejs timers implementation. The usage of bss values in drivers before initialisation of bss is forbidden. In that special case some data in .rel.dyn gets corrupted. This patch is similiar to the patch Dir