Re: [U-Boot] [PATCH v3] am3517_evm: activate Ethernet PHY

2013-12-06 Thread Yegor Yefremov
On Fri, Dec 6, 2013 at 1:14 PM, Tom Rini wrote: > On Fri, Dec 06, 2013 at 06:59:52AM -0500, Tom Rini wrote: >> On Fri, Dec 06, 2013 at 11:47:38AM +0100, Yegor Yefremov wrote: >> > On Fri, Dec 6, 2013 at 11:37 AM, Stefan Roese >> > wrote: >> > > On 06.12.2013 11:17, yegorsli...@googlemail.com wro

Re: [U-Boot] [PATCH v3] am3517_evm: activate Ethernet PHY

2013-12-06 Thread Tom Rini
On Fri, Dec 06, 2013 at 06:59:52AM -0500, Tom Rini wrote: > On Fri, Dec 06, 2013 at 11:47:38AM +0100, Yegor Yefremov wrote: > > On Fri, Dec 6, 2013 at 11:37 AM, Stefan Roese > > wrote: > > > On 06.12.2013 11:17, yegorsli...@googlemail.com wrote: > > >> From: Yegor Yefremov > > >> > > >> Pin 30 i

Re: [U-Boot] [PATCH v3] am3517_evm: activate Ethernet PHY

2013-12-06 Thread Tom Rini
On Fri, Dec 06, 2013 at 11:47:38AM +0100, Yegor Yefremov wrote: > On Fri, Dec 6, 2013 at 11:37 AM, Stefan Roese wrote: > > On 06.12.2013 11:17, yegorsli...@googlemail.com wrote: > >> From: Yegor Yefremov > >> > >> Pin 30 is connected to PHY's RESET# signal, so it must be > >> put to high. Otherwi

Re: [U-Boot] [PATCH v3] am3517_evm: activate Ethernet PHY

2013-12-06 Thread Yegor Yefremov
On Fri, Dec 6, 2013 at 11:37 AM, Stefan Roese wrote: > On 06.12.2013 11:17, yegorsli...@googlemail.com wrote: >> From: Yegor Yefremov >> >> Pin 30 is connected to PHY's RESET# signal, so it must be >> put to high. Otherwise PHY won't be found via MDIO interface. >> >> Signed-off-by: Yegor Yefremo

Re: [U-Boot] [PATCH v3] am3517_evm: activate Ethernet PHY

2013-12-06 Thread Stefan Roese
On 06.12.2013 11:17, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Pin 30 is connected to PHY's RESET# signal, so it must be > put to high. Otherwise PHY won't be found via MDIO interface. > > Signed-off-by: Yegor Yefremov Looks good. One questions below though: > --- > Changes

[U-Boot] [PATCH v3] am3517_evm: activate Ethernet PHY

2013-12-06 Thread yegorslists
From: Yegor Yefremov Pin 30 is connected to PHY's RESET# signal, so it must be put to high. Otherwise PHY won't be found via MDIO interface. Signed-off-by: Yegor Yefremov --- Changes: v3: use "__maybe_unused", instead of #if defined statement (Stefan Roese) v2: put ctr and rese