Re: [U-Boot] [PATCH v3] Nand driver for Nomadik SoC

2009-02-09 Thread Scott Wood
Alessandro Rubini wrote: >> From: Scott Wood > > Unfortunately freescale.com i.e. mail.global.frontbridge.com i.e. microsoft > has blacklisted me. I'm trying to do what they say but I fear you won't > get direct email. Hmm, I've e-mailed the postmaster inquiring as to why. Is there a specific

Re: [U-Boot] [PATCH v3] Nand driver for Nomadik SoC

2009-02-09 Thread Alessandro Rubini
> From: Scott Wood Unfortunately freescale.com i.e. mail.global.frontbridge.com i.e. microsoft has blacklisted me. I'm trying to do what they say but I fear you won't get direct email. >> +static inline int parity(int b) /* b is really a byte; returns 0 or ~0 */ > > If it's really a byte, then

Re: [U-Boot] [PATCH v3] Nand driver for Nomadik SoC

2009-02-09 Thread Scott Wood
On Sun, Feb 08, 2009 at 12:19:56AM +0100, Alessandro Rubini wrote: > +static inline int parity(int b) /* b is really a byte; returns 0 or ~0 */ If it's really a byte, then why not tell the compiler this with uint8_t? > +{ > + __asm__ __volatile__( > + "eor %0, %0, %0, lsr #4\n\t

Re: [U-Boot] [PATCH v3] Nand driver for Nomadik SoC

2009-02-09 Thread Stefan Roese
On Monday 09 February 2009, Alessandro Rubini wrote: > >> cpu/arm926ejs/nomadik/nand.c | > >> 221 > > > > This driver should go into drivers/mtd/nand instead. > > I've seen a lot of nand.c in board directories and three of them in > cpu directories (cpu

Re: [U-Boot] [PATCH v3] Nand driver for Nomadik SoC

2009-02-09 Thread Alessandro Rubini
>> cpu/arm926ejs/nomadik/nand.c | >> 221 > This driver should go into drivers/mtd/nand instead. I've seen a lot of nand.c in board directories and three of them in cpu directories (cpu/arm920t/s3c24x0/nand.c cpu/arm926ejs/nomadik/nand.c cpu/arm926ej

Re: [U-Boot] [PATCH v3] Nand driver for Nomadik SoC

2009-02-08 Thread Stefan Roese
On Sunday 08 February 2009, Alessandro Rubini wrote: > From: Alessandro Rubini > > This driver implements the ECC algorithm described in > the CPU data sheet and uses the OOB layout chosen in > already-released development systems (shipped with a custom-made > u-boot 1.3.1). > > Signed-off-by: Ale

[U-Boot] [PATCH v3] Nand driver for Nomadik SoC

2009-02-07 Thread Alessandro Rubini
From: Alessandro Rubini This driver implements the ECC algorithm described in the CPU data sheet and uses the OOB layout chosen in already-released development systems (shipped with a custom-made u-boot 1.3.1). Signed-off-by: Alessandro Rubini Acked-by: Andrea Gallo --- Changes from V2: added