Re: [U-Boot] [PATCH v3] Freescale NFC NAND driver

2010-01-25 Thread Wolfgang Denk
Dear "Yang, Lin", In message you wrote: > > Dear sir , This is a public mailing list. > We have used the PPC MPC5121 (m36p), and met some question about NAND flash, And what exactly are these questions? > Could you mind provide the newest driver about NAND flash to me, It's part of the

[U-Boot] [PATCH v3] Freescale NFC NAND driver

2010-01-24 Thread Yang, Lin
Dear sir , We have used the PPC MPC5121 (m36p), and met some question about NAND flash, Could you mind provide the newest driver about NAND flash to me, Thanks, yanglin The information in this email and attachments hereto may contain legally privileged, pro

Re: [U-Boot] [PATCH v3] Freescale NFC NAND driver

2009-06-04 Thread Scott Wood
John Rigby wrote: > My only concern is that the u-boot and linux nand drivers need to have the > same approach regarding ecc. The linux driver recently submitted only > supports sw ecc because using hw ecc means the spare area is not writeable. > The u-boot driver that I submitted supported hw_ecc

Re: [U-Boot] [PATCH v3] Freescale NFC NAND driver

2009-06-04 Thread John Rigby
Stefan, My only concern is that the u-boot and linux nand drivers need to have the same approach regarding ecc. The linux driver recently submitted only supports sw ecc because using hw ecc means the spare area is not writeable. The u-boot driver that I submitted supported hw_ecc only and was com

Re: [U-Boot] [PATCH v3] Freescale NFC NAND driver

2009-06-04 Thread Stefan Roese
Hi Scott, I'll try to continue with this patch so that we can integrate it hopefully soon. I already addressed some of your comments (the easy ones ;)). Please find some further questions below (I'm still new to the FSL NFC): On Thursday 06 November 2008 00:06:48 Scott Wood wrote: > > +static s

Re: [U-Boot] [PATCH v3] Freescale NFC NAND driver

2009-01-26 Thread Scott Wood
On Sat, Jan 24, 2009 at 12:27:04AM +0100, Wolfgang Denk wrote: > Dear John Rigby, > > In message <1225850561-751-1-git-send-email-jri...@freescale.com> you wrote: > > v3: Fixed problem with CFG vs CONFIG_SYS in board/ads5121/ads5121.c > > > > v2: Reworked MPC5121 NAND driver. > > Attempted to add

Re: [U-Boot] [PATCH v3] Freescale NFC NAND driver

2009-01-23 Thread Wolfgang Denk
Dear John Rigby, In message <1225850561-751-1-git-send-email-jri...@freescale.com> you wrote: > v3: Fixed problem with CFG vs CONFIG_SYS in board/ads5121/ads5121.c > > v2: Reworked MPC5121 NAND driver. > Attempted to address all the problems listed by Scott Wood. > Driver is now board independent

Re: [U-Boot] [PATCH v3] Freescale NFC NAND driver

2008-11-05 Thread Scott Wood
On Tue, Nov 04, 2008 at 07:02:41PM -0700, John Rigby wrote: > +#define MIN(x, y)((x < y) ? x : y) Please use the min() macro defined in include/common.h. > +static struct fsl_nfc_private { > + struct mtd_info mtd; > + char spare_only; > + char status_req; > + u16 col_a

Re: [U-Boot] [PATCH v3] Freescale NFC NAND driver

2008-11-05 Thread John Rigby
Fabio Estevam wrote: > >> +#define NFC_BUF_ADDR(NFC_REG_BASE + 0x1E04) >> +#define NFC_FLASH_ADDR (NFC_REG_BASE + 0x1E06) >> +#define NFC_FLASH_CMD (NFC_REG_BASE + 0x1E08) >> +#define NFC_CONFIG (NFC_REG_BASE + 0x1E

Re: [U-Boot] [PATCH v3] Freescale NFC NAND driver

2008-11-05 Thread Fabio Estevam
--- On Tue, 11/4/08, John Rigby <[EMAIL PROTECTED]> wrote: > From: John Rigby <[EMAIL PROTECTED]> > Subject: [U-Boot] [PATCH v3] Freescale NFC NAND driver > To: u-boot@lists.denx.de, "Scott Wood" <[EMAIL PROTECTED]> > Cc: "John Rigby" <[EMAIL

[U-Boot] [PATCH v3] Freescale NFC NAND driver

2008-11-04 Thread John Rigby
v3: Fixed problem with CFG vs CONFIG_SYS in board/ads5121/ads5121.c v2: Reworked MPC5121 NAND driver. Attempted to address all the problems listed by Scott Wood. Driver is now board independent. Will still need more work to be SOC independent. Driver for the NAND controller on MPC5121. This dri