Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-19 Thread Stefan Roese
On Sunday 19 July 2009 13:23:49 Matthias Fuchs wrote: > > > Either we use eeprom_write() or we use multiple call of i2c_write(). > > > If we do not change this, Stefan's code does not work with 405EP cpus. > > > On these you have 0x20 strapping bytes and typicall EEPROMs with 8 or > > > 16 bytes pa

Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-19 Thread Matthias Fuchs
Stefan, On Sunday 19 July 2009 09:55:10 Wolfgang Denk wrote: > Dear Matthias Fuchs, > > In message <4a619c0f.20...@esd.eu> you wrote: > > When writing more bytes to an eeprom than it's actual pagesize you have > > to take special care. This is done in eeprom_write(). i2c_write() to > > an eeprom o

Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-19 Thread Wolfgang Denk
Dear Matthias Fuchs, In message <4a619c0f.20...@esd.eu> you wrote: > > When writing more bytes to an eeprom than it's actual pagesize you have > to take special care. This is done in eeprom_write(). i2c_write() to > an eeprom only works with up to pagesize bytes! > > Either we use eeprom_write()

Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-18 Thread Matthias Fuchs
Hi Wolfgang, Wolfgang Denk schrieb: > Dear Matthias Fuchs, > > In message <200907172157.12244.matthias.fu...@esd.eu> you wrote: > ... > > [450+ lines of full quote deleted.] > > Please quote only relevant code snippets. Thanks. > >>> + for (i = 0; i < ppc4xx_config_count; i++) { >>> +

Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-17 Thread Wolfgang Denk
Dear Matthias Fuchs, In message <200907172157.12244.matthias.fu...@esd.eu> you wrote: ... [450+ lines of full quote deleted.] Please quote only relevant code snippets. Thanks. > > + for (i = 0; i < ppc4xx_config_count; i++) { > > + /* > > +* Search for configuration name

Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-17 Thread Matthias Fuchs
Please see one comment below On Friday 17 July 2009 15:53:56 Stefan Roese wrote: > This patch adds a generic command for programming I2C bootstrap > eeproms on PPC4xx. An implementation for Canyonlands board is > included. > > The command name is intentionally chosen not to be PPC4xx specific. > T

Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-17 Thread Wolfgang Denk
Dear Stefan Roese, In message <200907171905.07765...@denx.de> you wrote: > > > we could use something similar on some of the FSL SoCs. What about > > renaming this chip_config? When I see cpu I think of just CPU cores. > > "chip_config" is fine for me as well. If nobody objects or suggest somet

Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-17 Thread Stefan Roese
On Friday 17 July 2009 17:38:13 Kumar Gala wrote: > On Jul 17, 2009, at 8:53 AM, Stefan Roese wrote: > > This patch adds a generic command for programming I2C bootstrap > > eeproms on PPC4xx. An implementation for Canyonlands board is > > included. > > > > The command name is intentionally chosen n

Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-17 Thread Kumar Gala
On Jul 17, 2009, at 8:53 AM, Stefan Roese wrote: > This patch adds a generic command for programming I2C bootstrap > eeproms on PPC4xx. An implementation for Canyonlands board is > included. > > The command name is intentionally chosen not to be PPC4xx specific. > This way other CPU's/SoC's can i

Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-17 Thread Stefan Roese
On Friday 17 July 2009 16:39:35 Wolfgang Denk wrote: > Acked-by: Wolfgang Denk > > > Stefan, as this is mostly 4xx-related I suggest you run this through > the ppc_4xx repo. OK, will do. Thanks. Best regards, Stefan = DENX Soft

Re: [U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-17 Thread Wolfgang Denk
Dear Stefan Roese, In message <1247838836-20340-1-git-send-email...@denx.de> you wrote: > This patch adds a generic command for programming I2C bootstrap > eeproms on PPC4xx. An implementation for Canyonlands board is > included. > > The command name is intentionally chosen not to be PPC4xx speci

[U-Boot] [PATCH v3] Add "cpu_config" command for PPC4xx bootstrap configuration

2009-07-17 Thread Stefan Roese
This patch adds a generic command for programming I2C bootstrap eeproms on PPC4xx. An implementation for Canyonlands board is included. The command name is intentionally chosen not to be PPC4xx specific. This way other CPU's/SoC's can implement a similar command under the same name, perhaps with a