Re: [U-Boot] [PATCH v2 7/7] test/py: add spi_flash tests

2018-03-13 Thread Liam Beguin
Hi Stephen, On 13 March 2018 at 17:41, Stephen Warren wrote: > On 03/04/2018 09:22 PM, Liam Beguin wrote: >> >> Add basic tests for the spi_flash subsystem. > > > Looks good. A few small issues: > >> +def sf_prepare(u_boot_console, env__sf_config): > > ... >> >> +speed = env__sf_config.get('s

Re: [U-Boot] [PATCH v2 7/7] test/py: add spi_flash tests

2018-03-13 Thread Stephen Warren
On 03/04/2018 09:22 PM, Liam Beguin wrote: Add basic tests for the spi_flash subsystem. Looks good. A few small issues: +def sf_prepare(u_boot_console, env__sf_config): ... +speed = env__sf_config.get('speed', 0) +if isinstance(speed, list) and len(speed) == 2: +sf_params['s

[U-Boot] [PATCH v2 7/7] test/py: add spi_flash tests

2018-03-04 Thread Liam Beguin
Add basic tests for the spi_flash subsystem. Signed-off-by: Liam Beguin --- test/py/tests/test_sf.py | 223 +++ 1 file changed, 223 insertions(+) create mode 100644 test/py/tests/test_sf.py diff --git a/test/py/tests/test_sf.py b/test/py/tests/test_s