Re: [U-Boot] [PATCH v2 5/6] x86: Correct problems in the microcode loading

2014-12-16 Thread Simon Glass
On 16 December 2014 at 09:31, Simon Glass wrote: > Hi Bin, > > On 16 December 2014 at 02:41, Bin Meng wrote: >> Hi Simon, >> >> On Tue, Dec 16, 2014 at 1:02 PM, Simon Glass wrote: >>> There are several problems in the code. The device tree decode is incorrect >>> in ways that are masked due to a

Re: [U-Boot] [PATCH v2 5/6] x86: Correct problems in the microcode loading

2014-12-16 Thread Simon Glass
Hi Bin, On 16 December 2014 at 02:41, Bin Meng wrote: > Hi Simon, > > On Tue, Dec 16, 2014 at 1:02 PM, Simon Glass wrote: >> There are several problems in the code. The device tree decode is incorrect >> in ways that are masked due to a matching bug. Both are fixed. Also >> microcode_read_rev()

Re: [U-Boot] [PATCH v2 5/6] x86: Correct problems in the microcode loading

2014-12-16 Thread Bin Meng
Hi Simon, On Tue, Dec 16, 2014 at 1:02 PM, Simon Glass wrote: > There are several problems in the code. The device tree decode is incorrect > in ways that are masked due to a matching bug. Both are fixed. Also > microcode_read_rev() should be inline and called before the microcode is > written. >

[U-Boot] [PATCH v2 5/6] x86: Correct problems in the microcode loading

2014-12-15 Thread Simon Glass
There are several problems in the code. The device tree decode is incorrect in ways that are masked due to a matching bug. Both are fixed. Also microcode_read_rev() should be inline and called before the microcode is written. Note: microcode writing does not work correctly on ivybridge for me. Fur