Re: [U-Boot] [PATCH v2 5/6] TFTP: net/tftp.c: add server mode receive

2011-05-17 Thread Detlev Zundel
Hi Luca, [...] >> Hm, I have to admit that I do not really like adding so many ifdefs into >> the tftp code and even into the state machine code. Can you give me a >> number on how much larger u-boot gets on your platform with and without >> the server support? If this is not too much, maybe we

Re: [U-Boot] [PATCH v2 5/6] TFTP: net/tftp.c: add server mode receive

2011-05-17 Thread Luca Ceresoli
Detlev Zundel wrote: > Hi Luca, > >> Signed-off-by: Luca Ceresoli >> Cc: Wolfgang Denk >> --- >> Changes in v2: none. > Only one comment below > >> net/tftp.c | 72 >> --- >> net/tftp.h |6 + >> 2 files changed, 74 insertions(+

Re: [U-Boot] [PATCH v2 5/6] TFTP: net/tftp.c: add server mode receive

2011-04-19 Thread Detlev Zundel
Hi Luca, > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > --- > Changes in v2: none. Only one comment below > > net/tftp.c | 72 --- > net/tftp.h |6 + > 2 files changed, 74 insertions(+), 4 deletions(-) > > diff --git a/ne

[U-Boot] [PATCH v2 5/6] TFTP: net/tftp.c: add server mode receive

2011-04-18 Thread Luca Ceresoli
Signed-off-by: Luca Ceresoli Cc: Wolfgang Denk --- Changes in v2: none. net/tftp.c | 72 --- net/tftp.h |6 + 2 files changed, 74 insertions(+), 4 deletions(-) diff --git a/net/tftp.c b/net/tftp.c index e166a63..87eb0b8 100644 -