Re: [U-Boot] [PATCH v2 4/9] Stop using builtin_run_command()

2012-01-13 Thread Simon Glass
Hi Wolfgang, On Fri, Jan 13, 2012 at 1:33 PM, Simon Glass wrote: > Hi Wolfgang, > > On Fri, Jan 13, 2012 at 1:25 PM, Wolfgang Denk wrote: >> Dear Simon Glass, >> >> In message >> you >> wrote: >>> >>> > run_command2() in "common/main.c" (now renamed into run_command() will >>> > return 0 or 1

Re: [U-Boot] [PATCH v2 4/9] Stop using builtin_run_command()

2012-01-13 Thread Simon Glass
Hi Wolfgang, On Fri, Jan 13, 2012 at 1:25 PM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message > you > wrote: >> >> > run_command2() in "common/main.c" (now renamed into run_command() will >> > return 0 or 1 when used with the hush shell; it will never return < 0. >> >> Thanks for looki

Re: [U-Boot] [PATCH v2 4/9] Stop using builtin_run_command()

2012-01-13 Thread Wolfgang Denk
Dear Simon Glass, In message you wrote: > > > run_command2() in "common/main.c" (now renamed into run_command() will > > return 0 or 1 when used with the hush shell; it will never return < 0. > > Thanks for looking at this. I will see what I can figure out. I think there is some pre-existing

Re: [U-Boot] [PATCH v2 4/9] Stop using builtin_run_command()

2012-01-13 Thread Simon Glass
Hi Wolfgang, On Fri, Jan 13, 2012 at 11:27 AM, Wolfgang Denk wrote: > Dear Simon Glass, > > In message <1323542641-14541-5-git-send-email-...@chromium.org> you wrote: >> This function is only one of the parser options, so use run_command() >> instead. It knows how to use hush if selected. > ... >

Re: [U-Boot] [PATCH v2 4/9] Stop using builtin_run_command()

2012-01-13 Thread Wolfgang Denk
Dear Simon Glass, In message <1323542641-14541-5-git-send-email-...@chromium.org> you wrote: > This function is only one of the parser options, so use run_command() > instead. It knows how to use hush if selected. ... > debug("Starting %s process...\n", __FUNCTION__); > -#if !defined(CONFIG

[U-Boot] [PATCH v2 4/9] Stop using builtin_run_command()

2011-12-10 Thread Simon Glass
This function is only one of the parser options, so use run_command() instead. It knows how to use hush if selected. Signed-off-by: Simon Glass --- arch/arm/cpu/arm926ejs/kirkwood/cpu.c |7 + board/esd/common/auto_update.c|2 +- board/esd/common/cmd_loadpci.c|2 +